Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Chrome in webbrowser.py #57829

Closed
phdru mannequin opened this issue Dec 17, 2011 · 8 comments
Closed

Support Chrome in webbrowser.py #57829

phdru mannequin opened this issue Dec 17, 2011 · 8 comments
Labels
easy stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@phdru
Copy link
Mannequin

phdru mannequin commented Dec 17, 2011

BPO 13620
Nosy @birkenfeld, @phdru, @orsenthil
Files
  • webbrowser.py-2.patch
  • webbrowser_doc.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2011-12-21.14:33:42.918>
    created_at = <Date 2011-12-17.11:22:31.665>
    labels = ['easy', 'type-feature', 'library']
    title = 'Support Chrome in webbrowser.py'
    updated_at = <Date 2011-12-21.14:40:36.580>
    user = 'https://github.com/phdru'

    bugs.python.org fields:

    activity = <Date 2011-12-21.14:40:36.580>
    actor = 'pitrou'
    assignee = 'none'
    closed = True
    closed_date = <Date 2011-12-21.14:33:42.918>
    closer = 'orsenthil'
    components = ['Library (Lib)']
    creation = <Date 2011-12-17.11:22:31.665>
    creator = 'phd'
    dependencies = []
    files = ['24056', '24057']
    hgrepos = []
    issue_num = 13620
    keywords = ['patch', 'easy', 'needs review']
    message_count = 8.0
    messages = ['149666', '149885', '149886', '149890', '149891', '149893', '149990', '149992']
    nosy_count = 5.0
    nosy_names = ['georg.brandl', 'phd', 'orsenthil', 'python-dev', 'arnaudc']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue13620'
    versions = ['Python 3.3']

    @phdru
    Copy link
    Mannequin Author

    phdru mannequin commented Dec 17, 2011

    Support Google Chrome/Chromium browsers in webbrowser.py.

    The attached patch is against Python 2.7, but it should be applied cleanly to Python 3+.

    @phdru phdru mannequin added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Dec 17, 2011
    @pitrou pitrou added the easy label Dec 19, 2011
    @arnaudc
    Copy link
    Mannequin

    arnaudc mannequin commented Dec 19, 2011

    Hi.
    The patch works fine on my box with Chromium 16 under Archlinux.

    However, I think it might not work under Ubuntu or Debian, since the program is named "chromium-browser" on these distros, and it is missing from the list of tested browser. I am setting up an Ubuntu box to test and confirm this.

    @phdru
    Copy link
    Mannequin Author

    phdru mannequin commented Dec 19, 2011

    I updated the patch. Thank you for reviewing!

    @arnaudc
    Copy link
    Mannequin

    arnaudc mannequin commented Dec 19, 2011

    The new patch works under Ubuntu but not not under Archlinux anymore (where the program is named "chromium").

    Here is a patch that works with python 3.3 under both distributions.

    @phdru
    Copy link
    Mannequin Author

    phdru mannequin commented Dec 19, 2011

    I'm fine with that version.

    @arnaudc
    Copy link
    Mannequin

    arnaudc mannequin commented Dec 19, 2011

    Here is a patch against the 3.3 documentation, mentionning the new supported browser types.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Dec 21, 2011

    New changeset 7faa90a6324c by Senthil Kumaran in branch 'default':
    bpo-13620 - Support chrome browser in webbrowser.py module.
    http://hg.python.org/cpython/rev/7faa90a6324c

    New changeset bd3631f9aa5c by Senthil Kumaran in branch 'default':
    Docs and News update for bpo-13620. Chrome support in webbrowser.py
    http://hg.python.org/cpython/rev/bd3631f9aa5c

    @orsenthil
    Copy link
    Member

    orsenthil commented Dec 21, 2011

    This is in 3.3. Thanks for the patches.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    easy stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants