gh-64490: Fix refcount error when arguments are packed to tuple in argument clinic #99233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
colorfulappl
added a commit
to colorfulappl/cpython
that referenced
this pull request
Nov 8, 2022
Contributor
Author
|
Added Argument Clinic functional test (#96002). |
erlend-aasland
approved these changes
Nov 24, 2022
Contributor
erlend-aasland
left a comment
erlend-aasland
left a comment
There was a problem hiding this comment.
LGTM. Kumar, do you have any remarks?
kumaraditya303
added
type-bug
Contributor
|
Merged, thanks! |
Contributor
Author
|
Thank you! |
colorfulappl
added a commit
to colorfulappl/cpython
that referenced
this pull request
Dec 19, 2022
…o tuple in argument clinic (python#99233) (cherry picked from commit 69f6cc7)
|
GH-100338 is a backport of this pull request to the 3.11 branch. |
kumaraditya303
pushed a commit
that referenced
this pull request
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While Argument Clinic generated code is packing varargs to a tuple, the arguments' refcounts are not increased.
So all the packed arguments‘ refcounts are decreased 1 improperly when the tuple is released later.
This bug is found in #96178 "Argument Clinic functional test".