bpo-35348: platform.architecture() doc suggests sys.maxsize #11208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace also "may" with "can".
eamanu
approved these changes
Dec 18, 2018
vstinner
requested review from
serhiy-storchaka,
malemburg and
ronaldoussoren
| @@ -40,9 +40,12 @@ Cross Platform | |||
| and then only if the executable points to the Python interpreter. Reasonable | |||
| defaults are used when the above needs are not met. | |||
|
|
|||
| To only get the pointer size of the running Python interpreter, | |||
There was a problem hiding this comment.
sys.maxsize gives you the size of Py_ssize_t. On most platforms this is the same as the pointer size, but it is not guaranteed.
But I do not think that this addition is needed. platform.architecture() without arguments give you the bittness of the running Python interpreter. It does not try to guess it by parsing the file output.
|
Ok, I abandon my change in this case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue35348