Skip to content

Conversation

donBarbos
Copy link
Contributor

@donBarbos donBarbos commented Nov 18, 2024

Based on the last message I decided to make the this changes:

@ghost
Copy link

ghost commented Nov 18, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Nov 18, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@StanFromIreland
Copy link
Member

@gvanrossum This was originally your suggestion, what do you think? This PR which in my opinion is ready to merge as it completes the simple task has been forgotten about.

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I think there are a lot more important things that could be done to this file (it's too slow and I suspect it tests for a lot of compiler features that are always supported by C compilers that can compile CPython), (and I suspect that you are sending this PR so can claim to have contributed to CPython on your resume :-), this is clearly the right thing to do, so I'll merge it.

@gvanrossum gvanrossum enabled auto-merge (squash) January 26, 2025 16:56
@gvanrossum gvanrossum merged commit 5d9b620 into python:main Jan 26, 2025
46 checks passed
@donBarbos donBarbos deleted the delete-copyright-block branch January 31, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants