Skip to content

gh-130461: Remove unnecessary usages of .. index:: directives in Doc/library/uuid.rst #130526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 25, 2025
Merged

gh-130461: Remove unnecessary usages of .. index:: directives in Doc/library/uuid.rst #130526

merged 3 commits into from
Feb 25, 2025

Conversation

Mr-Sunglasses
Copy link
Contributor

@Mr-Sunglasses Mr-Sunglasses commented Feb 24, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir awaiting review labels Feb 24, 2025
@bedevere-app bedevere-app bot mentioned this pull request Feb 24, 2025
Closed
@Mr-Sunglasses
Copy link
Contributor Author

@picnixz , I've done the changes, Please Review it.

@Mr-Sunglasses @picnixz
chore: Update Misc/NEWS.d/next/Library/2025-02-25-03-53-00.gh-issue-1…
a4e30c5 
…30461.asr2dg.rst

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@picnixz picnixz requested review from hugovk and AA-Turner February 24, 2025 23:03
@picnixz picnixz mentioned this pull request Feb 24, 2025
Closed
hugovk
hugovk approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

picnixz added a commit to picnixz/cpython that referenced this pull request Feb 25, 2025
@picnixz
remove .. index:: directive in prevision of pythongh-130526
70872bf
@hugovk hugovk merged commit 85f1cc8 into python:main Feb 25, 2025
28 checks passed
@hugovk hugovk added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Feb 25, 2025
@miss-islington-app
Copy link

Thanks @Mr-Sunglasses for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @Mr-Sunglasses for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @Mr-Sunglasses and @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 85f1cc8d60b06d5b2af3e4da8e4f98171420dd91 3.12

@miss-islington-app
Copy link

Sorry, @Mr-Sunglasses and @hugovk, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 85f1cc8d60b06d5b2af3e4da8e4f98171420dd91 3.13

@picnixz
Copy link
Member

picnixz commented Feb 25, 2025

The conflicts are because uuid8 doesn't exist in 3.12/3.13 I think

@hugovk
Copy link
Member

hugovk commented Feb 25, 2025

@Mr-Sunglasses Please could you do the backports?

@Mr-Sunglasses
Copy link
Contributor Author

@Mr-Sunglasses Please could you do the backports?

Sure I'll do it :-)

@hugovk hugovk mentioned this pull request Feb 25, 2025
Merged
@Mr-Sunglasses Mr-Sunglasses mentioned this pull request Feb 25, 2025
Merged
@bedevere-app
Copy link

bedevere-app bot commented Feb 25, 2025

GH-130546 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 25, 2025
@Mr-Sunglasses Mr-Sunglasses mentioned this pull request Feb 25, 2025
Merged
Mr-Sunglasses added a commit to Mr-Sunglasses/cpython that referenced this pull request Feb 25, 2025
@Mr-Sunglasses @picnixz
pythongh-130461: Remove unnecessary usages of .. index:: directives…
dc6d1e3 
… in Doc/library/uuid.rst (python#130526)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
(cherry picked from commit 85f1cc8)
@bedevere-app
Copy link

bedevere-app bot commented Feb 25, 2025

GH-130548 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 25, 2025
@bedevere-app
Copy link

bedevere-app bot commented Feb 25, 2025

GH-130546 is a backport of this pull request to the 3.12 branch.

@bedevere-app
Copy link

bedevere-app bot commented Feb 25, 2025

GH-130548 is a backport of this pull request to the 3.13 branch.

hugovk pushed a commit that referenced this pull request Feb 25, 2025
@Mr-Sunglasses @picnixz
[3.13] gh-130461: Remove unnecessary usages of .. index:: directive…
28bfc1c 
…s in Doc/library/uuid.rst (#130526) (#130548)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
hugovk added a commit that referenced this pull request Feb 25, 2025
@Mr-Sunglasses @picnixz @hugovk
[3.12] gh-130461: Remove unnecessary usages of .. index:: directive…
ca9e52d 
…s in Doc/library/uuid.rst (#130526) (#130546)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@Mr-Sunglasses @picnixz @seehwan80
pythongh-130461: Remove unnecessary usages of .. index:: directives…
6172778 
… in Doc/library/uuid.rst (python#130526)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

@picnixz picnixz picnixz approved these changes

@AA-Turner AA-Turner Awaiting requested review from AA-Turner

Assignees

@hugovk hugovk

Labels
docs Documentation in the Doc dir
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unnecessary usages of .. index:: directives in Doc/library/uuid.rst
3 participants
@Mr-Sunglasses @picnixz @hugovk