-
-
Notifications
You must be signed in to change notification settings - Fork 33.1k
gh-138313: Suppress ResourceWarnings and restore skipped test #138597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 New build scheduled with the buildbot fleet by @jaraco for commit 43357c2 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F138597%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Seems to prevent the failure by giving the zip resource time to be garbage collected.
🤖 New build scheduled with the buildbot fleet by @jaraco for commit e8eb0d0 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F138597%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
🤖 New build scheduled with the buildbot fleet by @jaraco for commit c9f5305 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F138597%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
There are failures in BSD with the error "invalid line type". I assume those are ignorable. |
🤖 New build scheduled with the buildbot fleet by @jaraco for commit c1b4676 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F138597%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
I can see the refleaks PR builders are failing in test_capi since 3 days ago, so unrelated to these changes. I'm going to proceed with this change. I welcome others to come in and find an even more robust solution. |
Replaces the previous workaround (skip) with a less janky yet still janky workaround. See the log in the issue for details.
Closes #138313