Skip to content

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Sep 6, 2025

Replaces the previous workaround (skip) with a less janky yet still janky workaround. See the log in the issue for details.

Closes #138313

@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Sep 6, 2025
@jaraco jaraco added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 6, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @jaraco for commit 43357c2 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F138597%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 6, 2025
Seems to prevent the failure by giving the zip resource time to be garbage collected.
@jaraco jaraco added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 21, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @jaraco for commit e8eb0d0 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F138597%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 21, 2025
@jaraco jaraco marked this pull request as ready for review September 21, 2025 20:00
@jaraco jaraco requested a review from warsaw as a code owner September 21, 2025 20:00
@jaraco jaraco added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 21, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @jaraco for commit c9f5305 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F138597%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 21, 2025
@jaraco jaraco changed the title gh-138313: Fix ResourceWarnings and remove workaround gh-138313: Suppress ResourceWarnings and restore skipped test Sep 21, 2025
@jaraco
Copy link
Member Author

jaraco commented Sep 21, 2025

There are failures in BSD with the error "invalid line type". I assume those are ignorable.

@jaraco jaraco added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 21, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @jaraco for commit c1b4676 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F138597%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 21, 2025
@jaraco
Copy link
Member Author

jaraco commented Sep 22, 2025

I can see the refleaks PR builders are failing in test_capi since 3 days ago, so unrelated to these changes. I'm going to proceed with this change. I welcome others to come in and find an even more robust solution.

@jaraco jaraco merged commit a756a4b into python:main Sep 22, 2025
79 of 91 checks passed
@jaraco jaraco deleted the gh-138313 branch September 22, 2025 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ResourceWarnings in test_importlib in select buildbots

2 participants