Skip to content

gh-138313: Suppress ResourceWarnings and restore skipped test #138597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 22, 2025
Merged

gh-138313: Suppress ResourceWarnings and restore skipped test #138597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
43357c2
Remove workaround.
jaraco Sep 6, 2025
b682268
Remove workaround module.
jaraco Sep 21, 2025
e8eb0d0
Add a no-op in ZipFixture teardown.
jaraco Sep 21, 2025
b86082a
Add blurb
jaraco Sep 21, 2025
c9f5305
Merge branch 'main' into gh-138313
jaraco Sep 21, 2025
c1b4676
Remove dockerfile and test results.
jaraco Sep 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions Lib/test/test_importlib/metadata/_issue138313.py
View file
Open in desktop

This file was deleted.

2 changes: 2 additions & 0 deletions Lib/test/test_importlib/metadata/fixtures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,8 @@ def setUp(self):
# Add self.zip_name to the front of sys.path.
self.resources = contextlib.ExitStack()
self.addCleanup(self.resources.close)
# workaround for #138313
self.addCleanup(lambda: None)


def parameterize(*args_set):
Expand Down
2 changes: 0 additions & 2 deletions Lib/test/test_importlib/metadata/test_main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
)

from . import fixtures
from . import _issue138313
from ._path import Symlink


Expand Down Expand Up @@ -358,7 +357,6 @@ def test_packages_distributions_example(self):
self._fixture_on_path('example-21.12-py3-none-any.whl')
assert packages_distributions()['example'] == ['example']

@_issue138313.skip_on_buildbot
def test_packages_distributions_example2(self):
"""
Test packages_distributions on a wheel built
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Tests/2025-09-21-16-00-30.gh-issue-138313.lBx2en.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Restore skipped test and add janky workaround to prevent select buildbots
from failing with a ResourceWarning.
Loading