gh-91992: Fall back to UTF-8 if an unsupported locale is provided #139429
+33
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanFromIreland
commented
Sep 29, 2025
| text=True) | ||
| self.assertEqual(cmd.stdout.rstrip(), loc) | ||
|
|
||
| def test_unsupported_locale_fallback_to_utf8(self): |
There was a problem hiding this comment.
I'm not quite sure where to put this test.
|
I'm not sure it's a good idea to automatically modify the stdio encoding. If the locale encoding isn't available, how much likelihood is there that the application will function properly after Python starts? Wouldn't it be better to also produce an error if the user has set an incorrect PYTHONIOENCODING? |
|
If the user disabled UTF-8 mode, I think that it is incorrect to ignore this. Error is more preferable to producing mojibake. |
|
Ok, so I propose throwing a more informative error then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that on main UTF-8 mode is now default so this is only an issue if disabled.