gh-139495: Fix hashlib.file_digest() versionchanged description of BlockingIOError
#139496
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Error` The sentence was missing a negation and contradicted the other two descriptions in the same commit. I believe code behaviour is correct.
picnixz
reviewed
Oct 2, 2025
Misc/NEWS.d/next/Documentation/2025-10-02-11-51-34.gh-issue-139495.y4Orqf.rst
Outdated
Show resolved
Hide resolved
|
cc @cmaloney since you asked on the old PR |
|
The label "needs backport to 3.13" is probably applicable, matching #132787 |
|
Oh we backported it to 3.13. |
cmaloney
approved these changes
Oct 2, 2025
gpshead
approved these changes
Oct 2, 2025
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 2, 2025
…on of `BlockingIOError` (pythonGH-139496) * Fix `hashlib.file_digest()` versionchanged description of `BlockingIOError` The sentence was missing a negation and contradicted the other two descriptions in the same commit. I believe code behaviour is correct. * fixup! Fix `hashlib.file_digest()` versionchanged description of `BlockingIOError` * Remove unncessary NEWS.d entry (cherry picked from commit fb114cf) Co-authored-by: Alex Willmer <alex@moreati.org.uk>
|
Sorry, @moreati and @gpshead, I could not cleanly backport this to |
|
GH-139522 is a backport of this pull request to the 3.14 branch. |
|
GH-139528 is a backport of this pull request to the 3.13 branch. |
gpshead
pushed a commit
that referenced
this pull request
Oct 3, 2025
…ion of `BlockingIOError` (GH-139496) (#139528) * Fix `hashlib.file_digest()` versionchanged description of `BlockingIOError` The sentence was missing a negation and contradicted the other two descriptions in the same commit. I believe code behaviour is correct. * fixup! Fix `hashlib.file_digest()` versionchanged description of `BlockingIOError` * Remove unncessary NEWS.d entry (cherry picked from commit fb114cf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sentence was missing a negation and contradicted the other two descriptions in the same commit. I believe existing code behaviour is correct.
refs #122179, fixes #139495
BlockingIOErrorpre-condition in versionchanged note ofhashlib.file_digest()#139495📚 Documentation preview 📚: https://cpython-previews--139496.org.readthedocs.build/