Skip to content

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Oct 2, 2025

Christian Heimes is now inactive for 2 years.

Christian Heimes is now inactive for 2 years.
@vstinner
Copy link
Member Author

vstinner commented Oct 2, 2025

cc @gpshead @picnixz @tiran

@vstinner
Copy link
Member Author

vstinner commented Oct 2, 2025

IMO it's sending the wrong signal to require/request a review from @tiran on SSL and hashlib changes if he is inactive. That's why I propose removing him from CODEOWNERS.

Example of recent PR awaiting @tiran's review: #139496

Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think it makes sense to only keep active maintainers in CODEOWNERS.

Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I think we should see CODEOWNERS as 'automatically requested' rather than blocking/required reviews, see this section.

That being said, no objection to keeping the list up-to-date, it can provide the wrong signal to contributors that a review is requested, so they may be more reluctant to ask for updates etc. We can always add people back later, CODEOWNERS should be a fairly light-touch thing.

A

@vstinner vstinner merged commit 16da633 into python:main Oct 2, 2025
35 checks passed
@vstinner vstinner deleted the code_owners branch October 2, 2025 16:05
@vstinner
Copy link
Member Author

vstinner commented Oct 2, 2025

Merged. Thanks for reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants