Skip to content

[3.13] gh-139748: fix leaks in AC error paths when using unicode FS-b… #139792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2025
Merged

[3.13] gh-139748: fix leaks in AC error paths when using unicode FS-b… #139792

merged 2 commits into from
Oct 8, 2025

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Oct 8, 2025 •
edited by bedevere-app bot
Loading

@picnixz @kumaraditya303
[3.13] pythongh-139748: fix leaks in AC error paths when using unicod…
786b335 
…e FS-based converters (pythonGH-139765)

(cherry picked from commit b04a57d)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app bedevere-app bot mentioned this pull request Oct 8, 2025
Closed
@bedevere-app bedevere-app bot mentioned this pull request Oct 8, 2025
Merged
picnixz
picnixz reviewed Oct 8, 2025
View reviewed changes
@kumaraditya303 kumaraditya303 merged commit dac827c into python:3.13 Oct 8, 2025
50 checks passed
@kumaraditya303 kumaraditya303 deleted the backport-b04a57d-3.13 branch October 8, 2025 16:52
@vstinner
Copy link
Member

vstinner commented Oct 8, 2025

This change introduced a reference leak:

./python -m test test_socket -R 3:3 -m test.test_socket.GeneralModuleTests.testInterfaceNameIndex 
(...)
test_socket leaked [3, 3, 3] references, sum=9

I wrote #139815 to fix the regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz left review comments

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees

No one assigned

Labels

topic-argument-clinic

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kumaraditya303 @vstinner @picnixz