Skip to content

gh-82039: relax cookiejar.py case-sensitive regex for the inconsequential first line of the cookie file #15673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ashleyharvey
Copy link

@ashleyharvey ashleyharvey commented Sep 4, 2019

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@ashleyharvey ashleyharvey changed the title 37858: relax cookiejar.py case-sensitive regex for the inconsequential first line of the cookie file bpo-37858: relax cookiejar.py case-sensitive regex for the inconsequential first line of the cookie file Sep 4, 2019
@ashleyharvey
Copy link
Author

Apologies if I'm being obtuse, but, my PR has been in the queue for 3.5 years. Is there anything I need to do to get this approved and merged in?

@arhadthedev arhadthedev added the stdlib Python modules in the Lib dir label Feb 11, 2023
@bedevere-bot

This comment was marked as resolved.

@arhadthedev arhadthedev changed the title bpo-37858: relax cookiejar.py case-sensitive regex for the inconsequential first line of the cookie file gh-82039: relax cookiejar.py case-sensitive regex for the inconsequential first line of the cookie file Feb 11, 2023
@arhadthedev
Copy link
Member

@ashleyharvey Could you sign the new CLA by clicking not signed button in the cpython-cla-bot's message, please?

@ashleyharvey
Copy link
Author

@ashleyharvey Could you sign the new CLA by clicking not signed button in the cpython-cla-bot's message, please?

Done, I think? I got an internal server error multiple times but looking at the bot's comment above now, it says it's signed.

@ashleyharvey
Copy link
Author

Bump

@python python deleted a comment Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review stdlib Python modules in the Lib dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants