Skip to content

[3.8] bpo-37858: relax cookiejar.py case-sensitive regex for the inconsequential first line of the cookie file (GH-15673) #15679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ashleyharvey
Copy link

@ashleyharvey ashleyharvey commented Sep 4, 2019

…ejar.py

(the comment/header); add self to acks.
@gvanrossum gvanrossum removed the request for review from terryjreedy September 4, 2019 19:18
@ashleyharvey ashleyharvey changed the title [3.8] bpo-37858: loosen case-sensitive regex on inconsequential line in cookiejar.py (GH-15673) [3.8] bpo-37858: relax cookiejar.py case-sensitive regex for the inconsequential first line of the cookie file (GH-15673) Sep 4, 2019
@berkerpeksag berkerpeksag removed their request for review September 4, 2019 19:54
@ned-deily
Copy link
Member

Hi, @ashleyharvey. When proposing a fix like this, you should only open a PR against the master branch, which you did with #15673. Once it's been reviewed and merged, the core developer handling the merge will decide if it needs to be backported to other branches like 3.8 and 3.7 and we have tools that will normally automatically do the backports. To avoid further confusion, I'm closing this PR.

@ned-deily ned-deily closed this Sep 4, 2019
@ashleyharvey
Copy link
Author

Hi, @ashleyharvey. When proposing a fix like this, you should only open a PR against the master branch, which you did with #15673. Once it's been reviewed and merged, the core developer handling the merge will decide if it needs to be backported to other branches like 3.8 and 3.7 and we have tools that will normally automatically do the backports. To avoid further confusion, I'm closing this PR.

Understood, thank you. Will it go all the way back to 2.7, or is that up to the core dev?

@ashleyharvey ashleyharvey deleted the fix-issue-37858-3.8 branch September 4, 2019 21:06
@ned-deily
Copy link
Member

That's generally up to the core dev but 2.7 is about to reach end-of-life so we are trying to minimize the number of changes going there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants