Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
bpo-29535: Not all datetime objects are using hashing randomization #1937
changed the title
Not all datetime objects are using hashing randomization (issue29535)
Mar 26, 2018
abalkin left a comment
It is not clear what "some datetime objects" include. Is it some subset of date, time, datetime, timezone types or some instances of these types get randomized hash and some don't? If we are going to document the current implementation we should explain precisely which objects have deterministic hash and which don't.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase
And if you don't make the requested changes, you will be put in the comfy chair!