Skip to content

gh-86819: Add ISO-TP CAN socket constants #23794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

gh-86819: Add ISO-TP CAN socket constants #23794

wants to merge 3 commits into from

Conversation

rumpelsepp
Copy link
Contributor

@rumpelsepp rumpelsepp commented Dec 16, 2020 •
edited by bedevere-app bot
Loading

This adds constants to the socket module which are provided by the new isotp module available in Linux >= 5.10.

https://bugs.python.org/issue42653
#86819

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@rumpelsepp

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@shawnl
Copy link

shawnl commented Dec 16, 2020 •
edited
Loading

As the reporter or the original feature request this patch looks good to me.

(Although I hate autoconf magic)

@rumpelsepp
Copy link
Contributor Author

(Although I hate autoconf magic)

As do I… Is there anything else I have to adjust here? My autoreconf version seems different and it mutilates the checked in configure script.

@vstinner
Copy link
Member

Please open a new issue: https://bugs.python.org/issue10141 is closed.

@rumpelsepp rumpelsepp changed the title bpo-10141: Add constants for isotp.h which is included in Linux >= 5.10 issue42653: Add constants for isotp.h which is included in Linux >= 5.10 Dec 16, 2020
@rumpelsepp rumpelsepp changed the title issue42653: Add constants for isotp.h which is included in Linux >= 5.10 bpo-42653: Add constants for isotp.h which is included in Linux >= 5.10 Dec 16, 2020
@rumpelsepp
Copy link
Contributor Author

done

tiran
tiran previously requested changes Dec 16, 2020
View reviewed changes
Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include a blurb and leave the CAN_ISOTP macro in place.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

@rumpelsepp
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@tiran: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from tiran December 16, 2020 09:30
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jan 16, 2021
@tiran tiran removed their request for review April 17, 2021 21:16
@rumpelsepp
Copy link
Contributor Author

Am I supposed to do any more changes here?

@menschel menschel mentioned this pull request May 19, 2021
Closed
@rumpelsepp rumpelsepp force-pushed the isotp branch 4 times, most recently from c287165 to 0c4ed7d Compare February 28, 2022 23:47
@bedevere-app
Copy link

bedevere-app bot commented Jul 16, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@rumpelsepp
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Jul 16, 2024

Thanks for making the requested changes!

@erlend-aasland, @tiran: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from erlend-aasland July 16, 2024 08:37
picnixz
picnixz reviewed Jul 27, 2024
View reviewed changes
@rumpelsepp rumpelsepp force-pushed the isotp branch 3 times, most recently from f86112a to bd7eecf Compare July 30, 2024 05:53
@rumpelsepp rumpelsepp requested a review from picnixz July 30, 2024 05:54
@rumpelsepp
Copy link
Contributor Author

@picnixz I addressed your review.

picnixz
picnixz approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing my nitpicking review!

erlend-aasland
erlend-aasland reviewed Sep 3, 2024
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, but I have some nits to pick.

menschel and others added 2 commits September 4, 2024 15:34
@erlend-aasland erlend-aasland changed the title gh-86819: Add constants for isotp.h which is included in Linux >= 5.10 gh-86819: Add ISO-TP CAN socket constants Oct 14, 2024
@erlend-aasland erlend-aasland dismissed tiran’s stale review October 14, 2024 22:12

Christian's concerns were addressed: a NEWS blurb was added, and the CAN_ISOTP macro was left in place.

@erlend-aasland erlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 14, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit ffae37c 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@tiran tiran Awaiting requested review from tiran

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees
No one assigned
Labels
awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@rumpelsepp @the-knights-who-say-ni @shawnl @vstinner @bedevere-bot @menschel @tiran @picnixz @erlend-aasland @ezio-melotti