New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message for invalid package names passed to mypy #3447

Merged
merged 2 commits into from May 26, 2017

Conversation

Projects
None yet
2 participants
@chernrick
Contributor

chernrick commented May 25, 2017

Addresses issue #2775

Show outdated Hide outdated mypy/main.py
targets.append(BuildSource(f, crawl_up(f)[1], None))
try:
targets.append(BuildSource(f, crawl_up(f)[1], None))
except ValueError as e:

This comment has been minimized.

@gvanrossum

gvanrossum May 25, 2017

Member

Can you change this to catch the ValueError only from crawl_up(f)? It would be even better if the latter function returned a special result (maybe None) or (even more better :-) raised a dedicated exception, instead of essentially crashing with ValueError. Ditto for expand_dir(f) below (though there at least the scope of the except clause is sufficiently limited).

@gvanrossum

gvanrossum May 25, 2017

Member

Can you change this to catch the ValueError only from crawl_up(f)? It would be even better if the latter function returned a special result (maybe None) or (even more better :-) raised a dedicated exception, instead of essentially crashing with ValueError. Ditto for expand_dir(f) below (though there at least the scope of the except clause is sufficiently limited).

@chernrick

This comment has been minimized.

Show comment
Hide comment
@chernrick

chernrick May 25, 2017

Contributor

@gvanrossum Thank you for the review! I have added an InvalidPackageName exception.

Contributor

chernrick commented May 25, 2017

@gvanrossum Thank you for the review! I have added an InvalidPackageName exception.

@gvanrossum gvanrossum merged commit 4d61418 into python:master May 26, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gvanrossum

This comment has been minimized.

Show comment
Hide comment
@gvanrossum

gvanrossum May 26, 2017

Member

Thanks for the PR! It's merged now.

Member

gvanrossum commented May 26, 2017

Thanks for the PR! It's merged now.

carljm added a commit to carljm/mypy that referenced this pull request May 30, 2017

Merge branch 'master' into module-alias
* master: (23 commits)
  Make return type of open() more precise (#3477)
  Add test cases that delete a file during incremental checking (#3461)
  Parse each format-string component separately (#3390)
  Don't warn about returning Any if it is a proper subtype of the return type (#3473)
  Add __setattr__ support (#3451)
  Remove bundled lib-typing (#3337)
  Move version of extensions to post-release (#3348)
  Fix None slice bounds with strict-optional (#3445)
  Allow NewType subclassing NewType. (#3465)
  Add console scripts (#3074)
  Fix 'variance' label.
  Change label for variance section to just 'variance' (#3429)
  Better error message for invalid package names passed to mypy (#3447)
  Fix last character cut in html-report if file does not end with newline (#3466)
  Print pytest output as it happens (#3463)
  Add mypy roadmap (#3460)
  Add flag to avoid interpreting arguments with a default of None as Optional (#3248)
  Add type checking plugin support for functions (#3299)
  Mismatch of inferred type and return type note (#3428)
  Sync typeshed (#3449)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment