Skip to content

Respect follow-imports=silent in warn-unused-ignores #4857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2018
Merged

Respect follow-imports=silent in warn-unused-ignores #4857

merged 2 commits into from
Apr 4, 2018

Conversation

msullivan
Copy link
Collaborator

Closes #3949

@msullivan msullivan requested a review from gvanrossum April 4, 2018 21:36
emmatyping
emmatyping approved these changes Apr 4, 2018
View reviewed changes
Copy link
Member

@emmatyping emmatyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@msullivan msullivan merged commit 0689731 into master Apr 4, 2018
@msullivan msullivan deleted the silent-type-ignore branch April 4, 2018 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmatyping emmatyping emmatyping approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msullivan @emmatyping