New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve stub testing to cover all of typeshed #5051

Merged
merged 9 commits into from Jul 20, 2018

Conversation

Projects
None yet
4 participants
@ethanhs
Collaborator

ethanhs commented May 15, 2018

This will fail until typeshed is synced with python/typeshed#2130 and python/typeshed#2121

Previously, we were only checking 2and3, 3.3-3.5 and 3. This checks 3.6, 3.7 and 2.

@JelleZijlstra

This comment has been minimized.

Show comment
Hide comment
@JelleZijlstra

JelleZijlstra May 15, 2018

Collaborator

Would it be possible to replace this by an invocation of tests/mypy_test.py in the typeshed submodule using mypy from the current repository? That way we don't have to maintain two slightly different versions of the same logic.

Collaborator

JelleZijlstra commented May 15, 2018

Would it be possible to replace this by an invocation of tests/mypy_test.py in the typeshed submodule using mypy from the current repository? That way we don't have to maintain two slightly different versions of the same logic.

ethanhs added some commits May 15, 2018

This was referenced May 16, 2018

@ethanhs

This comment has been minimized.

Show comment
Hide comment
@ethanhs

ethanhs May 27, 2018

Collaborator

@JelleZijlstra IIRC you now want to do the opposite, replace the check in typeshed with this one? Is that right? Once this is merged it should be easy to just invoke this from typeshed.

Collaborator

ethanhs commented May 27, 2018

@JelleZijlstra IIRC you now want to do the opposite, replace the check in typeshed with this one? Is that right? Once this is merged it should be easy to just invoke this from typeshed.

@JelleZijlstra

This comment has been minimized.

Show comment
Hide comment
@JelleZijlstra

JelleZijlstra May 27, 2018

Collaborator

I don't feel very strongly about this, but apparently this uncovered bugs in typeshed that typeshed's own tests didn't find, so it would be better to run this test in typeshed itself.

Collaborator

JelleZijlstra commented May 27, 2018

I don't feel very strongly about this, but apparently this uncovered bugs in typeshed that typeshed's own tests didn't find, so it would be better to run this test in typeshed itself.

@ilevkivskyi

This comment has been minimized.

Show comment
Hide comment
@ilevkivskyi

ilevkivskyi Jun 25, 2018

Collaborator

What is the status of this PR? runtests.py is going to be removed soon, so I am wondering if this is still relevant.

Collaborator

ilevkivskyi commented Jun 25, 2018

What is the status of this PR? runtests.py is going to be removed soon, so I am wondering if this is still relevant.

@ethanhs

This comment has been minimized.

Show comment
Hide comment
@ethanhs

ethanhs Jun 25, 2018

Collaborator

test_stubs has moved in #5142, I think we should still change the tests to cover all of typeshed. I will modify this to change the pytest test instead of what is in runtests.py

Collaborator

ethanhs commented Jun 25, 2018

test_stubs has moved in #5142, I think we should still change the tests to cover all of typeshed. I will modify this to change the pytest test instead of what is in runtests.py

ethanhs added some commits Jun 26, 2018

@ethanhs

This comment has been minimized.

Show comment
Hide comment
@ethanhs

ethanhs Jun 26, 2018

Collaborator

Okay this now targets the pytest test. I decided to split each version into its own test so pytest can parrallelize them.

Collaborator

ethanhs commented Jun 26, 2018

Okay this now targets the pytest test. I decided to split each version into its own test so pytest can parrallelize them.

@Michael0x2a

FWIW, this PR looks good to me, apart from a few minor nits.

Unless there are any objections, I think I'm going to just merge this in once Ethan has a chance to look through my feedback?

Show outdated Hide outdated mypy/test/testsamples.py Outdated
Show outdated Hide outdated mypy/test/testsamples.py Outdated
Show outdated Hide outdated mypy/test/testsamples.py Outdated

@Michael0x2a Michael0x2a merged commit 3bcc8bf into python:master Jul 20, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ethanhs ethanhs deleted the ethanhs:morestubchk branch Jul 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment