Migrate stdlibsamples test to pytest #5271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check as files instead of as modules, without changing cwd.
JelleZijlstra
approved these changes
Jun 25, 2018
|
I'd like @JukkaL to have a quick look -- he presumably remembers why we have this test in the first place. |
Merged
|
These are regression tests we've had from the early days of mypy. They aren't very useful any more, but I think it's worth keeping them as they provide a sense of historical perspective, at the very least. |
JukkaL
approved these changes
Jun 25, 2018
ethanhs
approved these changes
Jun 25, 2018
|
Thanks Elazar for powering through these issues! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check as files instead of as modules, without changing cwd.
As far as I understand, this should be the last step of #1673 before removal of
runtests.pyandwaiter.py.(completes #5142)