Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate stdlibsamples test to pytest #5271

Merged
merged 1 commit into from Jun 25, 2018

Conversation

Projects
None yet
5 participants
@elazarg
Copy link
Contributor

elazarg commented Jun 25, 2018

Check as files instead of as modules, without changing cwd.

As far as I understand, this should be the last step of #1673 before removal of runtests.py and waiter.py.

(completes #5142)

Migrate stdlibsamples test to pytest
Check as files instead of as modules, without changing cwd.
@gvanrossum

This comment has been minimized.

Copy link
Member

gvanrossum commented Jun 25, 2018

I'd like @JukkaL to have a quick look -- he presumably remembers why we have this test in the first place.

@elazarg elazarg referenced this pull request Jun 25, 2018

Merged

Remove runtests.py #5274

@JukkaL

This comment has been minimized.

Copy link
Collaborator

JukkaL commented Jun 25, 2018

These are regression tests we've had from the early days of mypy. They aren't very useful any more, but I think it's worth keeping them as they provide a sense of historical perspective, at the very least.

@JukkaL

JukkaL approved these changes Jun 25, 2018

@gvanrossum gvanrossum merged commit eb3a3dd into python:master Jun 25, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gvanrossum

This comment has been minimized.

Copy link
Member

gvanrossum commented Jun 25, 2018

Thanks Elazar for powering through these issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.