Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MYPYC_BLACKLIST on Windows #7032

Merged
merged 1 commit into from Jun 21, 2019

Conversation

@ethanhs
Copy link
Collaborator

commented Jun 21, 2019

This simple error has an unfortunately far reaching effect :(

The compiled __main__.py file doesn't work, so dmypy is broken with mypy 0.710 on Windows, which this fixes.

Closes #7031

@ethanhs ethanhs requested a review from msullivan Jun 21, 2019

@msullivan
Copy link
Collaborator

left a comment

Thanks for catching this.

We may need to release a 0.711 with this cherry-picked.

@ethanhs ethanhs merged commit 48916e6 into master Jun 21, 2019

3 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ethanhs ethanhs deleted the fixdmypywin branch Jun 21, 2019

@ilevkivskyi

This comment has been minimized.

Copy link
Collaborator

commented Jun 21, 2019

It is of course up to @gvanrossum but I would say it makes sense to make a point release.

@JukkaL

This comment has been minimized.

Copy link
Collaborator

commented Jun 21, 2019

Yeah a point release seems worth it.

@JelleZijlstra

This comment has been minimized.

Copy link
Collaborator

commented Jun 21, 2019

If we do do a point release, can I request that python/typeshed#3077 be included?

@gvanrossum

This comment has been minimized.

Copy link
Member

commented Jun 21, 2019

Yes, I agree we should also include python/typeshed#3077. (I think this would have to be done by branching typeshed to cherry-pick just that change, and then setting the mypy release branch to use that branch as its submodule.

Can this wait until Monday?

@gvanrossum gvanrossum referenced this pull request Jun 21, 2019

Closed

Release 0.711 planning #7039

JelleZijlstra added a commit to JelleZijlstra/mypy that referenced this pull request Jun 22, 2019

Fix MYPYC_BLACKLIST on Windows (python#7032)
This fixes an issue with dmypy run not working on Windows introduced in python#6851.

PattenR added a commit to PattenR/mypy that referenced this pull request Jun 23, 2019

Fix MYPYC_BLACKLIST on Windows (python#7032)
This fixes an issue with dmypy run not working on Windows introduced in python#6851.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.