Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some paragraphs of the doc are not translated in French. #1153

Merged
merged 8 commits into from
Feb 18, 2020
Merged

some paragraphs of the doc are not translated in French. #1153

merged 8 commits into from
Feb 18, 2020

Conversation

ananthan-123
Copy link
Contributor

@ananthan-123 ananthan-123 commented Feb 17, 2020

Fix #1152

@ananthan-123 ananthan-123 changed the title bpo-1152:some paragraphs of the doc are not translated in French. some paragraphs of the doc are not translated in French. Feb 17, 2020
Copy link
Contributor

@vpoulailleau vpoulailleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

One change to be done, you should execute powrap to fix the indentation of the file.

It seems that this PR closes #1152, you should add "Fix #1152" to the PR description.

@ananthan-123
Copy link
Contributor Author

can anyone tell me how to run powrap.

@vpoulailleau
Copy link
Contributor

You need to activate the virtual environment in your "project", that depends on the OS you are using. That may be source venv/bin/activate under Linux.

Once the environment is activated, you can then run the command powrap tutorial/interpreter.po and it'll fix the file. Then you have to commit and push the modifications.

In your "simple case", only one line is too long: line 61. You can move the last word of the line to the beginning of the next line, and you'll be as strong as powrap 💪

@ananthan-123
Copy link
Contributor Author

I can't see any mistakes now.

@vpoulailleau
Copy link
Contributor

Sorry, it's my bad, I am not as strong as powrap.

The expected result by powrap is (notice the end of lines):

"Sur les machines Windows sur lesquelles vous avez installé Python à partir "
"du :ref:`Microsoft Store <windows-store>`, la commande :file:`python3.8` "
"sera disponible. Si le :ref:`py.exe launcher <launcher>` est installé, vous "
"pouvez utiliser la commande :file:`py`. Voir :ref:`setting-envvars` pour "
"d'autres façons de lancer Python."

I made you move the wrong word. The good word to move was "pour". If you update the file, powrap will be happy (I've tested with powrap!)

@ananthan-123
Copy link
Contributor Author

hurray!! The test is passed.

@vpoulailleau
Copy link
Contributor

@Seluj78 @awecx @JulienPalard This needs a review, LGTM.

@Seluj78 Seluj78 merged commit d1b2055 into python:3.8 Feb 18, 2020
@Seluj78
Copy link
Collaborator

Seluj78 commented Feb 18, 2020

Merci pour cette correction @ananthan-123 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

some paragraphs of the doc are not translated in French
3 participants