Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

possible grammar problem on PEP8 page #1387

Closed
carmella-smith opened this issue Feb 21, 2019 · 3 comments
Closed

possible grammar problem on PEP8 page #1387

carmella-smith opened this issue Feb 21, 2019 · 3 comments

Comments

@carmella-smith
Copy link

In the section here:
https://www.python.org/dev/peps/pep-0008/#descriptive-naming-styles
it says:
_single_leading_underscore: weak "internal use" indicator. E.g. from M import * does not import objects whose name starts with an underscore.
I would change it to:
_single_leading_underscore: weak "internal use" indicator. E.g. from M import * does not import objects whose names start with an underscore.
@Mariatta
Copy link
Member

Thank you. I think this issue is better raised at the PEPs repo at https://github.com/python/peps
Would you mind opening the issue there? Thanks.

Mariatta added a commit to python/peps that referenced this issue Mar 13, 2019
@Mariatta
PEP 8: minor grammar improvement
266a9a5 
From 
> does not import objects whose name starts with an underscore.
into
> does not import objects whose names start with an underscore.

Closes python/pythondotorg#1387
@Mariatta Mariatta mentioned this issue Mar 13, 2019
Merged
gvanrossum pushed a commit to python/peps that referenced this issue Mar 13, 2019
@Mariatta @gvanrossum
PEP 8: minor grammar improvement (#926)
2f8f1ec 
From 
> does not import objects whose name starts with an underscore.
into
> does not import objects whose names start with an underscore.

Closes python/pythondotorg#1387
@gvanrossum
Copy link
Member

Please close now.

@carmella-smith
Copy link
Author

Looks good; thanks for fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gvanrossum @Mariatta @carmella-smith