Fix issue 883 #1036
Closed
Fix issue 883 #1036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No problem, thanks for the PR! :) I will take a look at it this weekend. |
|
Hello, any update about this PR? |
|
Oops, sorry about that :( Please ping me again if I don't review/merge this by Saturday. |
|
Merged in a1658e9, thanks! I hope you will continue to send high quality pull requests like this :) |
|
(I will test this on https://staging.python.org/ for a while then deploy it to production.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, sorry for giving you any update on this, it took me longer than I had originally thought.
Anyway, I tried to apply the least changes to fix the misbehaviour, but there's still room for improvements, at a cost of some larger changes in the code (e.g., move the tag in the /events/ page, so to make it not use absolute positioning to show it on the left).
Let me know if there still are some changes to be made. Cheers!