Skip to content

Conversation

ewdurbin
Copy link
Member

@ewdurbin ewdurbin commented Nov 16, 2020

  • Eliminate “New” display on the benefits selection form
  • Only show the “At Capacity” once anything has reached capacity!
  • Format $ as commas and USD.
  • Note: Highlighting for all benefits in a package has some kind of bug. Reproduce: Select “visionary” and look at “Language Summit recognition”
  • Confirmation list of selected benefits on the Sponsor Application page could use formatting/bullets
  • Add hover over pop up to display ‘benefit description’ field from python.org/admin/sponsors/sponsorshipbenefit/
  • Update copy across benefit selection, sponsor form, and submission confirmation
  • Add a CMS editable box for top of benefits selection form
  • Allow a group access for sponsorship preview/soft-launch

Comment on lines +35 to +40
capacities_met = any(
[
any([not b.has_capacity for b in benefits_qs.filter(program=p)])
for p in programs
]
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I didn't get why we have to filter the benefits_qs by program to check if there's one of them without available capacity. Can't we refactor the code to:

Suggested change
capacities_met = any(
[
any([not b.has_capacity for b in benefits_qs.filter(program=p)])
for p in programs
]
)
capacities_met = all([b.has_capacity for b in benefits_qs])

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this primarily since I anticipate that at some point we will have programs that are no longer active. a bit premature.

@berinhard
Copy link
Contributor

@ewdurbin I updated this PR fixing the remaining 2 items (benefit description + selection highlight bug). Feel free to review, test and merge this PR if nothing else pops up. I'm attaching 2 screen shots as quick demos:

benefit description
Screenshot from 2020-11-16 10-29-03

all benefits are now highlighted
Screenshot from 2020-11-16 10-54-19

@ewdurbin ewdurbin force-pushed the sponsor_application_flow_feedback branch from dd7bc62 to 89cc56e Compare November 16, 2020 14:46
@ewdurbin ewdurbin force-pushed the sponsor_application_flow_feedback branch from 2fbd486 to b743a59 Compare November 16, 2020 20:00
@ewdurbin ewdurbin merged commit 515c333 into master Nov 16, 2020
@ewdurbin ewdurbin deleted the sponsor_application_flow_feedback branch November 16, 2020 20:07
@JackieAugustine
Copy link

benefit description + selection highlight bug has reappeared. Explanation: when selecting a package some 'benefits' do not highlight in blue'

@ewdurbin
Copy link
Member Author

@JackieAugustine thanks, but this is probably related to #1687, not this Pull Request.

@ewdurbin
Copy link
Member Author

@JackieAugustine fix for that is introduced in #1688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants