Bugfix: enable to execute draft contracts #1916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of the contract detail under Django's admin. It changes the
signed_documentfield to be a read-only and, thus, avoid PSF staff from by-passing the views that ensures the control of the objects states. It also adds displays that Execute button that was only being displayed for contracts under "Awaiting Signature" state. This button leads to the same old execute contract page, but now it requires a new input for the user to upload the signed contract before executing it.Signed document as read only
New button being displayed for a draft contract
Execute contract page with file input
State of the contract after a valid submit