feature/return and raise #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes it so that when an exception is thrown in the `step` method of SecurityContext, if it has an attached token, the token is returned and the exception and traceback are saved. The exception and traceback will be reraised by `complete` the next time it is checked.
Also only set structure members if the corresponding python variable is not None, avoid using GSS_C_AF_NULLADDR by default as address values are protocol dependent, only the caller knows what is the convention for each application protocol. Signed-off-by: Simo Sorce <simo@redhat.com>
Commit 12e88c3 miscopied the sizeof call, allocating the size of a pointer instead of the size of the underlying struct. This fixes that.
Previously, `_last_err` was only check on complete. It is now checked on every method. This ensures that the error actually gets thrown, and makes it more likely that the stored traceback actually gets deleted. This functionality can now be disabled by setting the `__DEFER_STEP_ERRORS__` class variable in `SecurityContext` to `False`.
Python 3 automatically saves the traceback with exceptions and uses it when reraising the exception, so we don't have to manually save the traceback. Also, just use "raise" instead of six.reraise when simply choosing to raise the exception without saving it.
This was referenced Aug 21, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.