Skip to content

Specify units in docstrings for all lifetime fields/parameters. #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

judilsteve
Copy link

A better solution would be to add properties like lifetime_ts that return the lifetime as a timespan, and maybe accept lifetime values as timestamps, with a quick lifetime = lifetime.total_seconds if isinstance(lifetime, timespan) else lifetime at the top of any function that accepts a lifetime parameter.

But for now this should at least avoid confusing people.

@jborean93
Copy link
Contributor

Thanks @judilsteve for the PR, when you get a chance are you able to sign off this commit with

git commit --amend --no-edit --signoff
git push --force-with-lease origin in_seconds

@jborean93
Copy link
Contributor

These fixes were incorporated with #285.

@jborean93 jborean93 closed this Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants