Add basic import with assertions check #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cython 3 generates code which fails on Python that was built with assertions enabled. This commit adds the upper bound version until this issue has been fixed. CI has been updated to test out this specific scenario. Signed-off-by: Jordan Borean <jborean93@gmail.com>
jborean93
force-pushed
the
ci-with-assertions
branch
from
787f2db to
4c7199f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is designed to do basic tests with a Python build with
--with-assertions. It also caps the Cython version to less than 3 until it fixes the issue causing the referenced issue.Fixes: #327