Skip to content

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Oct 9, 2019

Signed-off-by: Edward Z. Yang ezyang@fb.com

ezyang and others added 4 commits October 9, 2019 13:00
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
…wnloading from sourceforge (#280)

* Add a retry to adjust for network failures when downloading from sourceforge

* try to fix packaging by adding longer connection timeout
* Add a retry to adjust for network failures when downloading from sourceforge
* fix packaging by adding longer connection timeout
* Updated URL for downloading flac, changed http to https download
* Removed comments that are documented in the code
@vincentqb vincentqb self-requested a review October 10, 2019 15:19
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need this to be merged?

@vincentqb
Copy link
Contributor

I would have expected a change like #261 (which has been reverted) to be needed for torchaudio to be compatible with the latest pytorch version?

@ezyang
Copy link
Contributor Author

ezyang commented Oct 11, 2019

@vincentqb I merged it myself.

Re #261 it looks like it was only deprecated and not removed

@vincentqb
Copy link
Contributor

vincentqb commented Oct 16, 2019

@ezyang I notice that the version available on pip is 0.3.0 which requires pytorch 1.2.0. I don't have access to the binaries. Can you update the version to 0.3.1?

This appears to be causing issue in pytorch/tutorials#687, see comment.

@ezyang
Copy link
Contributor Author

ezyang commented Oct 17, 2019

@soumith can you please give @vincentqb maintainership on torchaudio

@ezyang
Copy link
Contributor Author

ezyang commented Oct 17, 2019

Should be fixed. For reference, I ran:

cd builder/wheel
./publish_wheels.sh torchaudio-0.3.1
./upload_wheels_to_pypi.sh torchaudio-0.3.1

@soumith
Copy link
Member

soumith commented Oct 17, 2019

@ezyang @vincentqb you are already an admin of the repo Vincent. You and christian are.

@vincentqb
Copy link
Contributor

vincentqb commented Oct 17, 2019

Thanks for the instructions @ezyang!

Yes, I am an admin on github @soumith. Do I need to be listed as a maintainer on pypi also? I see ezyang who is a maintainer on pypi written in upload_wheels_to_pypi.sh, and my pypi username vincentqb is not on the list of maintainers on pypi.

@soumith
Copy link
Member

soumith commented Oct 17, 2019

oh, can add you on pypi. what is your pypi username?

@soumith
Copy link
Member

soumith commented Oct 17, 2019

you already gave your pypi username, i couldn't read. adding you in 1 min

@soumith
Copy link
Member

soumith commented Oct 17, 2019

added

@benfei
Copy link

benfei commented Oct 23, 2019

can you please upload this version to the "pytorch" conda channel as well?

@vincentqb
Copy link
Contributor

vincentqb commented Oct 23, 2019

@soumith -- my username is also vincentqb on anaconda.com.

@soumith
Copy link
Member

soumith commented Oct 24, 2019

@vincentqb added on conda

@vincentqb
Copy link
Contributor

vincentqb commented Oct 24, 2019

As shown here, the files were uploaded using builder/conda/publish_conda.sh:

cd builder/conda
./publish_conda.sh torchaudio==0.3.1

@ezyang The error in #307 does not occur anymore, but when I print the version number I see 0.3.0+120f693 instead of 0.3.1 when installing with conda instead of pip.

conda:

conda create -n pytorch-conda python=3.7
conda activate pytorch-conda
conda install -c conda-forge sox
conda install -c pytorch torchaudio
python -c "import torch; print(torch.__version__); import torchaudio; print(torchaudio.__version__);"

1.3.0
0.3.0+120f693

pip:

conda create -n pytorch-pip python=3.7
conda activate pytorch-pip
pip install torchaudio
python -c "import torch; print(torch.__version__); import torchaudio; print(torchaudio.__version__);"

1.3.0
0.3.1

@benfei
Copy link

benfei commented Oct 26, 2019

@soumith @vincentqb
thanks!

@vincentqb vincentqb mentioned this pull request Mar 25, 2020
1 task
@mthrok mthrok mentioned this pull request Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants