-
Notifications
You must be signed in to change notification settings - Fork 728
0.3.1 point release #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.3.1 point release #308
Conversation
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
…wnloading from sourceforge (#280) * Add a retry to adjust for network failures when downloading from sourceforge * try to fix packaging by adding longer connection timeout
* Add a retry to adjust for network failures when downloading from sourceforge * fix packaging by adding longer connection timeout
* Updated URL for downloading flac, changed http to https download * Removed comments that are documented in the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need this to be merged?
I would have expected a change like #261 (which has been reverted) to be needed for torchaudio to be compatible with the latest pytorch version? |
@vincentqb I merged it myself. Re #261 it looks like it was only deprecated and not removed |
@ezyang I notice that the version available on pip is 0.3.0 which requires pytorch 1.2.0. I don't have access to the binaries. Can you update the version to 0.3.1? This appears to be causing issue in pytorch/tutorials#687, see comment. |
@soumith can you please give @vincentqb maintainership on torchaudio |
Should be fixed. For reference, I ran:
|
@ezyang @vincentqb you are already an admin of the repo Vincent. You and christian are. |
Thanks for the instructions @ezyang! Yes, I am an admin on github @soumith. Do I need to be listed as a maintainer on pypi also? I see |
oh, can add you on pypi. what is your pypi username? |
you already gave your pypi username, i couldn't read. adding you in 1 min |
added |
can you please upload this version to the "pytorch" conda channel as well? |
@soumith -- my username is also |
@vincentqb added on conda |
As shown here, the files were uploaded using builder/conda/publish_conda.sh:
@ezyang The error in #307 does not occur anymore, but when I print the version number I see conda:
pip:
|
@soumith @vincentqb |
Signed-off-by: Edward Z. Yang ezyang@fb.com