Skip to content

Conversation

vincentqb
Copy link
Contributor

To generate binaries: wheels and conda in #308.

jamarshon and others added 17 commits July 31, 2019 09:57
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
* Packaging improvements for nightlies

- Instructions for how to install stable and master binaries,
  without hardcoding wheel filenames
- Turn on Python 2 build (numba is only needed for testing)
- Make builds a little more hermetic
- Prefer building against nightly CPU-only torch build
- Don't install all of requirements.txt, it's not necessary
- Updates for OS X too, including portability issues

Signed-off-by: Edward Z. Yang <ezyang@fb.com>
(cherry picked from commit 4542332)
* Rewrite our packaging from scratch (pytorch#217)

* New entry points are packaging/build_wheel.sh and packaging/build_conda.sh. The only mandatory environment variable you have to set is PYTHON_VERSION
* CircleCI configuration uses 2.1-style parametrized builds to let you toggle python version, etc. as you do builds. We create a separate job per build configuration for maximum parallelism
* build_tools/packaging got moved to packaging, to be in-line with directory structure in torchvision
* The build_conda.sh and build_wheel.sh delegate most of the heavy lifting to pkg_helpers.bash, which defines a number of bash functions for performing common operations. The intent is that I'll copy-paste this file between other domain API projects.
* TORCHAUDIO_ prefix removed from envvars, so that I can more easily share packaging scripts between projects
* BUILD_VERSION is completely gone; just change the version number if you need to rebuild
* No more logic for cloning and checking out a fresh copy of torchaudio

* Setup cuda_suffix (pytorch#218)

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

* Add uploading support (pytorch#220)

Also bugfixes and updates to the packaging scripts.

* Finish up and set parameters

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

* Updates from vision

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

* Go time

Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
…h#223) (pytorch#225)

* Refactor version suffix so conda packages don't get suffixes.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

* typofix

Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
…wnloading from sourceforge (pytorch#280)

* Add a retry to adjust for network failures when downloading from sourceforge

* try to fix packaging by adding longer connection timeout
* Add a retry to adjust for network failures when downloading from sourceforge
* fix packaging by adding longer connection timeout
…orch#297)

* Updated URL for downloading flac, changed http to https download
* Removed comments that are documented in the code
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
@vincentqb vincentqb requested a review from ezyang November 25, 2019 21:39
@vincentqb vincentqb closed this Nov 25, 2019
@vincentqb vincentqb deleted the v0.3.2 branch November 25, 2019 21:40
@vincentqb vincentqb restored the v0.3.2 branch November 25, 2019 21:40
@vincentqb vincentqb deleted the v0.3.2 branch November 25, 2019 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants