Skip to content

Remove EXECUTORCH_SEPARATE_FLATCC_HOST_PROJECT #10860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

Remove EXECUTORCH_SEPARATE_FLATCC_HOST_PROJECT #10860

merged 1 commit into from
May 13, 2025

Conversation

jathu
Copy link
Contributor

@jathu jathu commented May 13, 2025 •
edited by pytorch-bot bot
Loading

Summary

I forgot to do this in #10855. But since we build flatcc for the host now, we don't need this variable.

Test plan

CI

$ rg EXECUTORCH_SEPARATE_FLATCC_HOST_PROJECT --hidden -g '!.git/'

cc @larryliu0820

@jathu jathu added module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch ciflow/trunk ciflow/binaries release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. labels May 13, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 13, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10860

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

⏳ No Failures, 4 Pending

As of commit 2736355 with merge base 518324f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 13, 2025
@jathu jathu marked this pull request as ready for review May 13, 2025 21:27
@jathu jathu merged commit 4a89327 into main May 13, 2025
292 checks passed
@jathu jathu deleted the jathu/remove-EXECUTORCH_SEPARATE_FLATCC_HOST_PROJECT branch May 13, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larryliu0820 larryliu0820 larryliu0820 approved these changes

@kirklandsign kirklandsign Awaiting requested review from kirklandsign

@mergennachin mergennachin Awaiting requested review from mergennachin mergennachin is a code owner

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

Assignees

No one assigned

Labels

ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jathu @larryliu0820 @facebook-github-bot