Skip to content

Remove EXECUTORCH_SEPARATE_FLATCC_HOST_PROJECT #10860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged

Remove EXECUTORCH_SEPARATE_FLATCC_HOST_PROJECT #10860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .ci/scripts/build-qnn-sdk.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@ set_up_aot() {
-DEXECUTORCH_BUILD_EXTENSION_MODULE=ON \
-DEXECUTORCH_BUILD_EXTENSION_TENSOR=ON \
-DEXECUTORCH_ENABLE_EVENT_TRACER=ON \
-DPYTHON_EXECUTABLE=python3 \
-DEXECUTORCH_SEPARATE_FLATCC_HOST_PROJECT=OFF
-DPYTHON_EXECUTABLE=python3
cmake --build $PWD --target "PyQnnManagerAdaptor" "PyQnnWrapperAdaptor" -j$(nproc)
# install Python APIs to correct import path
# The filename might vary depending on your Python and host version.
Expand Down
2 changes: 0 additions & 2 deletions backends/arm/scripts/build_executorch.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ if [ "$build_with_etdump" = true ] ; then
-DEXECUTORCH_BUILD_EXTENSION_RUNNER_UTIL=ON \
-DEXECUTORCH_BUILD_DEVTOOLS=ON \
-DEXECUTORCH_ENABLE_EVENT_TRACER=ON \
-DEXECUTORCH_SEPARATE_FLATCC_HOST_PROJECT=ON \
-DFLATCC_ALLOW_WERROR=OFF \
-B"${et_build_host_dir}" \
"${et_root_dir}"
Expand Down Expand Up @@ -111,7 +110,6 @@ if [ "$build_with_etdump" = true ] ; then
# Add DevTools flags use in the Target build below
build_with_etdump_flags="-DEXECUTORCH_BUILD_DEVTOOLS=ON \
-DEXECUTORCH_ENABLE_EVENT_TRACER=ON \
-DEXECUTORCH_SEPARATE_FLATCC_HOST_PROJECT=OFF \
-DEXECUTORCH_BUILD_EXTENSION_DATA_LOADER=OFF \
-DFLATCC_ALLOW_WERROR=OFF \
-DFLATCC_EXECUTABLE=${et_build_host_dir}/bin/flatcc "
Expand Down
3 changes: 1 addition & 2 deletions docs/source/backends-qualcomm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,7 @@ cmake .. \
-DEXECUTORCH_BUILD_EXTENSION_MODULE=ON \
-DEXECUTORCH_BUILD_EXTENSION_TENSOR=ON \
-DEXECUTORCH_ENABLE_EVENT_TRACER=ON \
-DPYTHON_EXECUTABLE=python3 \
-DEXECUTORCH_SEPARATE_FLATCC_HOST_PROJECT=OFF
-DPYTHON_EXECUTABLE=python3

# nproc is used to detect the number of available CPU.
# If it is not applicable, please feel free to use the number you want.
Expand Down
5 changes: 0 additions & 5 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,11 +714,6 @@ def run(self): # noqa C901
"-DEXECUTORCH_ENABLE_LOGGING=ON",
"-DEXECUTORCH_LOG_LEVEL=Info",
"-DCMAKE_OSX_DEPLOYMENT_TARGET=10.15",
# The separate host project is only required when cross-compiling,
# and it can cause build race conditions (libflatcc.a errors) when
# enabled. TODO(dbort): Remove this override once this option is
# managed by cmake itself.
"-DEXECUTORCH_SEPARATE_FLATCC_HOST_PROJECT=OFF",
"-DEXECUTORCH_BUILD_TESTS=ON",
]

Expand Down
Loading