remove sleef_arm target #11082
Merged
remove sleef_arm target #11082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swolchok
requested review from
JacobSzwejbka,
lucylq and
manuelcandales
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11082
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit f39ed1d with merge base 4014cc6 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74356413 |
swolchok
added a commit
to swolchok/pytorch
that referenced
this pull request
May 23, 2025
Summary: Pull Request resolved: pytorch#154166 X-link: pytorch/executorch#11082 We shouldn't need an ARM-specific variant; we have select() where we should need it. Test Plan: CI Reviewed By: kimishpatel, malfet, nlutsenko Differential Revision: D74356413
|
This pull request was exported from Phabricator. Differential Revision: D74356413 |
swolchok
added a commit
to swolchok/executorch
that referenced
this pull request
May 23, 2025
Summary: X-link: pytorch/pytorch#154166 Pull Request resolved: pytorch#11082 We shouldn't need an ARM-specific variant; we have select() where we should need it. Reviewed By: kimishpatel, malfet, nlutsenko Differential Revision: D74356413
kimishpatel
approved these changes
May 23, 2025
Summary: X-link: pytorch/pytorch#154166 We shouldn't need an ARM-specific variant; we have select() where we should need it. Reviewed By: kimishpatel, malfet, nlutsenko Differential Revision: D74356413
swolchok
force-pushed
the
export-D74356413
branch
from
7c118c9 to
f39ed1d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74356413 |
swolchok
force-pushed
the
export-D74356413
branch
from
47d5a61 to
7c118c9
Compare
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
May 23, 2025
Summary: X-link: pytorch/executorch#11082 We shouldn't need an ARM-specific variant; we have select() where we should need it. Test Plan: CI Reviewed By: nlutsenko Differential Revision: D74356413 Pull Request resolved: #154166 Approved by: https://github.com/kimishpatel, https://github.com/malfet, https://github.com/Skylion007
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We shouldn't need an ARM-specific variant; we have select() where we should need it.
Reviewed By: nlutsenko
Differential Revision: D74356413