Skip to content

Remove setting BUCK2 when building the wheel #11490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2025
Merged

Remove setting BUCK2 when building the wheel #11490

merged 1 commit into from
Jun 9, 2025

Conversation

jathu
Copy link
Contributor

@jathu jathu commented Jun 9, 2025 •
edited by pytorch-bot bot
Loading

Summary

This is unnecessary since we resolve buck2 in cmake already:

executorch/CMakeLists.txt

Lines 78 to 81 in 8f05c35

if(NOT BUCK2)
resolve_buck2()
endif()
announce_configured_options(BUCK2)

Test plan

CI

cc @larryliu0820

@jathu jathu requested a review from larryliu0820 June 9, 2025 17:03
@jathu jathu added module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch ciflow/trunk ciflow/binaries release notes: none Do not include this in the release notes labels Jun 9, 2025
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 9, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 9, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11490

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 5 Pending

As of commit d12c6b8 with merge base 8f05c35 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@jathu jathu marked this pull request as ready for review June 9, 2025 17:12
@jathu jathu merged commit 00ab9f6 into main Jun 9, 2025
213 checks passed
@jathu jathu deleted the jathu/setup-no-buck branch June 9, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larryliu0820 larryliu0820 larryliu0820 approved these changes

Assignees
No one assigned
Labels
ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch release notes: none Do not include this in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jathu @larryliu0820 @facebook-github-bot