Skip to content

Remove setting BUCK2 when building the wheel #11490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025
Merged

Remove setting BUCK2 when building the wheel #11490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,9 +656,6 @@ def run(self): # noqa C901
# get_python_lib() typically returns the path to site-packages, where
# all pip packages in the environment are installed.
cmake_prefix_path = os.environ.get("CMAKE_PREFIX_PATH", get_python_lib())
buck2 = os.environ.get(
"BUCK2_EXECUTABLE", os.environ.get("BUCK2", os.environ.get("BUCK", ""))
)
# Put the cmake cache under the temp directory, like
# "pip-out/temp.<plat>/cmake-out".
pip_build_dir = os.path.join(
Expand All @@ -668,7 +665,6 @@ def run(self): # noqa C901
self.mkpath(cmake_cache_dir)

cmake_configuration_args = [
f"-DBUCK2={buck2}",
f"-DPYTHON_EXECUTABLE={sys.executable}",
# Let cmake calls like `find_package(Torch)` find cmake config files
# like `TorchConfig.cmake` that are provided by pip packages.
Expand Down
Loading