Skip to content

Conversation

larryliu0820
Copy link
Contributor

This PR simplifies README.md's cmake command by using preset.
This pull request simplifies the build process for the Llama model and its runner by introducing a preset configuration and removing redundant build flags. Additionally, it updates the CMakeLists.txt file to enable specific features for tokenizers.

Build process simplification:

  • examples/models/llama/README.md: Replaced the detailed cmake commands with a preset configuration (--preset llm) for building executorch and removed redundant flags for the Llama runner build process. This streamlines the instructions and reduces complexity.

Tokenizer configuration updates:

  • extension/llm/runner/CMakeLists.txt: Added SUPPORT_REGEX_LOOKAHEAD and PCRE2_STATIC_PIC settings to enable regex lookahead support and ensure position-independent code for tokenizers.

This PR simplifies README.md's cmake command by using preset.
Copy link

pytorch-bot bot commented Jun 11, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11543

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 4 Unrelated Failures

As of commit cf99195 with merge base c6c3616 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 11, 2025
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Contributor

@guangy10 guangy10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the instructions tested in the CI? If all green, should we merge this PR?

@larryliu0820 larryliu0820 merged commit 5a45132 into main Jun 11, 2025
428 of 446 checks passed
@larryliu0820 larryliu0820 deleted the readme_preset branch June 11, 2025 23:45
@larryliu0820
Copy link
Contributor Author

Are the instructions tested in the CI? If all green, should we merge this PR?

Yeah the same command in test_llama.sh in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants