-
Notifications
You must be signed in to change notification settings - Fork 684
[llm] Fix llama/README.md #11543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[llm] Fix llama/README.md #11543
Conversation
This PR simplifies README.md's cmake command by using preset.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11543
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 4 Unrelated FailuresAs of commit cf99195 with merge base c6c3616 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the instructions tested in the CI? If all green, should we merge this PR?
Yeah the same command in |
This PR simplifies README.md's cmake command by using preset.
This pull request simplifies the build process for the Llama model and its runner by introducing a preset configuration and removing redundant build flags. Additionally, it updates the
CMakeLists.txt
file to enable specific features for tokenizers.Build process simplification:
examples/models/llama/README.md
: Replaced the detailedcmake
commands with a preset configuration (--preset llm
) for building executorch and removed redundant flags for the Llama runner build process. This streamlines the instructions and reduces complexity.Tokenizer configuration updates:
extension/llm/runner/CMakeLists.txt
: AddedSUPPORT_REGEX_LOOKAHEAD
andPCRE2_STATIC_PIC
settings to enable regex lookahead support and ensure position-independent code for tokenizers.