[ET-VK] 6/n Split dispatches between multiple command buffers. Replaced encode_execute function with invalidate_execute_encoding and moved encoding logic to execute function().
#13016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed `encode_execute` function with `invalidate_execute_encoding` and moved encoding logic to execute function(). This diff removes `encode_execute()` function. Differential Revision: [D78581574](https://our.internmc.facebook.com/intern/diff/D78581574/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13016
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 2592f49 with merge base 439bb6c ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
trivedivivek
added a commit
that referenced
this pull request
Jul 30, 2025
…ed `encode_execute` function with `invalidate_execute_encoding` and moved encoding logic to execute function(). This diff removes `encode_execute()` function. Differential Revision: [D78581574](https://our.internmc.facebook.com/intern/diff/D78581574/) ghstack-source-id: 297169585 Pull Request resolved: #13016
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78581574 |
…ers. Replaced `encode_execute` function with `invalidate_execute_encoding` and moved encoding logic to execute function()." This diff removes `encode_execute()` function. Differential Revision: [D78581574](https://our.internmc.facebook.com/intern/diff/D78581574/) [ghstack-poisoned]
trivedivivek
added a commit
that referenced
this pull request
Jul 31, 2025
…ed `encode_execute` function with `invalidate_execute_encoding` and moved encoding logic to execute function(). Pull Request resolved: #13016 This diff removes `encode_execute()` function and moves its functionality to `execute()`. `execute()` function automatically encodes command buffers when `deferred_cmd_list_` is empty. Differential Revision: [D78581574](https://our.internmc.facebook.com/intern/diff/D78581574/) ghstack-source-id: 299661241
|
This pull request was exported from Phabricator. Differential Revision: D78581574 |
SS-JIA
approved these changes
Jul 31, 2025
…ers. Replaced `encode_execute` function with `invalidate_execute_encoding` and moved encoding logic to execute function()." This diff removes `encode_execute()` function. Differential Revision: [D78581574](https://our.internmc.facebook.com/intern/diff/D78581574/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D78581574 |
trivedivivek
added
the
release notes: vulkan
…ers. Replaced `encode_execute` function with `invalidate_execute_encoding` and moved encoding logic to execute function()." This diff removes `encode_execute()` function. Differential Revision: [D78581574](https://our.internmc.facebook.com/intern/diff/D78581574/) [ghstack-poisoned]
trivedivivek
added a commit
that referenced
this pull request
Jul 31, 2025
…ed `encode_execute` function with `invalidate_execute_encoding` and moved encoding logic to execute function(). Pull Request resolved: #13016 This diff removes `encode_execute()` function and moves its functionality to `execute()`. `execute()` function automatically encodes command buffers when `deferred_cmd_list_` is empty. ghstack-source-id: 299987383 Differential Revision: [D78581574](https://our.internmc.facebook.com/intern/diff/D78581574/)
|
This pull request was exported from Phabricator. Differential Revision: D78581574 |
facebook-github-bot
merged commit b3c357b
into
gh/trivedivivek/128/base
101 of 104 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
trivedivivek
added a commit
that referenced
this pull request
Aug 1, 2025
…ed `encode_execute` function with `invalidate_execute_encoding` and moved encoding logic to execute function(). (#13054) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #13016 by @trivedivivek ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/128/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/128/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/128/orig @diff-train-skip-merge Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>
agrima1304
pushed a commit
to agrima1304/executorch
that referenced
this pull request
Aug 26, 2025
…ed `encode_execute` function with `invalidate_execute_encoding` and moved encoding logic to execute function(). (pytorch#13054) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: pytorch#13016 by @trivedivivek ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/128/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/128/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/128/orig @diff-train-skip-merge Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
encode_executefunction withinvalidate_execute_encodingand moved encoding logic to execute function(). #13016This diff removes
encode_execute()function.Differential Revision: D78581574