[ET-VK] 6/n Split dispatches between multiple command buffers. Replaced encode_execute function with invalidate_execute_encoding and moved encoding logic to execute function().
#13054
+15
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed `encode_execute` function with `invalidate_execute_encoding` and moved encoding logic to execute function(). Pull Request resolved: #13016 This diff removes `encode_execute()` function and moves its functionality to `execute()`. `execute()` function automatically encodes command buffers when `deferred_cmd_list_` is empty. ghstack-source-id: 299987383 Differential Revision: [D78581574](https://our.internmc.facebook.com/intern/diff/D78581574/)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13054
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New FailureAs of commit aad9576 with merge base 439bb6c ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
trivedivivek
approved these changes
Aug 1, 2025
trivedivivek
added
the
release notes: vulkan
agrima1304
pushed a commit
to agrima1304/executorch
that referenced
this pull request
Aug 26, 2025
…ed `encode_execute` function with `invalidate_execute_encoding` and moved encoding logic to execute function(). (pytorch#13054) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: pytorch#13016 by @trivedivivek ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/128/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/128/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/128/orig @diff-train-skip-merge Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #13016 by @trivedivivek
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/128/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/128/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/128/orig
@diff-train-skip-merge