Use extension module for pybind #13717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate the module class in pybindings, previously it was blocked by bundled program, and now it's resolved with https://github.com/pytorch/executorch/blob/2bb567f15a54fbc0ef621e5e85ff24e5da505b11/extension/module/bundled_module.h#L4 Differential Revision: [D70516347](https://our.internmc.facebook.com/intern/diff/D70516347/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Aug 26, 2025
Deprecate the module class in pybindings, previously it was blocked by bundled program, and now it's resolved with https://github.com/pytorch/executorch/blob/2bb567f15a54fbc0ef621e5e85ff24e5da505b11/extension/module/bundled_module.h#L4 Differential Revision: [D70516347](https://our.internmc.facebook.com/intern/diff/D70516347/) ghstack-source-id: 305831069 Pull Request resolved: #13717
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13717
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New FailureAs of commit c06f423 with merge base 2107afa ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70516347 |
This PR needs a
|
Deprecate the module class in pybindings, previously it was blocked by bundled program, and now it's resolved with https://github.com/pytorch/executorch/blob/2bb567f15a54fbc0ef621e5e85ff24e5da505b11/extension/module/bundled_module.h#L4 Differential Revision: [D70516347](https://our.internmc.facebook.com/intern/diff/D70516347/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Aug 26, 2025
Pull Request resolved: #13717 Deprecate the module class in pybindings, previously it was blocked by bundled program, and now it's resolved with https://github.com/pytorch/executorch/blob/2bb567f15a54fbc0ef621e5e85ff24e5da505b11/extension/module/bundled_module.h#L4 ghstack-source-id: 305832320 @exported-using-ghexport Differential Revision: [D70516347](https://our.internmc.facebook.com/intern/diff/D70516347/)
|
This pull request was exported from Phabricator. Differential Revision: D70516347 |
Deprecate the module class in pybindings, previously it was blocked by bundled program, and now it's resolved with https://github.com/pytorch/executorch/blob/2bb567f15a54fbc0ef621e5e85ff24e5da505b11/extension/module/bundled_module.h#L4 Differential Revision: [D70516347](https://our.internmc.facebook.com/intern/diff/D70516347/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Aug 27, 2025
Pull Request resolved: #13717 Deprecate the module class in pybindings, previously it was blocked by bundled program, and now it's resolved with https://github.com/pytorch/executorch/blob/2bb567f15a54fbc0ef621e5e85ff24e5da505b11/extension/module/bundled_module.h#L4 ghstack-source-id: 305994827 @exported-using-ghexport Differential Revision: [D70516347](https://our.internmc.facebook.com/intern/diff/D70516347/)
|
This pull request was exported from Phabricator. Differential Revision: D70516347 |
Deprecate the module class in pybindings, previously it was blocked by bundled program, and now it's resolved with https://github.com/pytorch/executorch/blob/2bb567f15a54fbc0ef621e5e85ff24e5da505b11/extension/module/bundled_module.h#L4 Differential Revision: [D70516347](https://our.internmc.facebook.com/intern/diff/D70516347/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Aug 27, 2025
Pull Request resolved: #13717 Deprecate the module class in pybindings, previously it was blocked by bundled program, and now it's resolved with https://github.com/pytorch/executorch/blob/2bb567f15a54fbc0ef621e5e85ff24e5da505b11/extension/module/bundled_module.h#L4 ghstack-source-id: 306001495 @exported-using-ghexport Differential Revision: [D70516347](https://our.internmc.facebook.com/intern/diff/D70516347/)
|
This pull request was exported from Phabricator. Differential Revision: D70516347 |
lucylq
changed the title
JacobSzwejbka
approved these changes
Aug 27, 2025
Deprecate the module class in pybindings, previously it was blocked by bundled program, and now it's resolved with https://github.com/pytorch/executorch/blob/2bb567f15a54fbc0ef621e5e85ff24e5da505b11/extension/module/bundled_module.h#L4 Differential Revision: [D70516347](https://our.internmc.facebook.com/intern/diff/D70516347/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Aug 29, 2025
Pull Request resolved: #13717 Deprecate the module class in pybindings, previously it was blocked by bundled program, and now it's resolved with https://github.com/pytorch/executorch/blob/2bb567f15a54fbc0ef621e5e85ff24e5da505b11/extension/module/bundled_module.h#L4 ghstack-source-id: 306001495 @exported-using-ghexport Differential Revision: [D70516347](https://our.internmc.facebook.com/intern/diff/D70516347/)
|
This pull request was exported from Phabricator. Differential Revision: D70516347 |
Deprecate the module class in pybindings, previously it was blocked by bundled program, and now it's resolved with https://github.com/pytorch/executorch/blob/2bb567f15a54fbc0ef621e5e85ff24e5da505b11/extension/module/bundled_module.h#L4 Differential Revision: [D70516347](https://our.internmc.facebook.com/intern/diff/D70516347/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Aug 30, 2025
Pull Request resolved: #13717 Deprecate the module class in pybindings, previously it was blocked by bundled program, and now it's resolved with https://github.com/pytorch/executorch/blob/2bb567f15a54fbc0ef621e5e85ff24e5da505b11/extension/module/bundled_module.h#L4 ghstack-source-id: 306625833 @exported-using-ghexport Differential Revision: [D70516347](https://our.internmc.facebook.com/intern/diff/D70516347/)
|
This pull request was exported from Phabricator. Differential Revision: D70516347 |
facebook-github-bot
merged commit 7715cb0
into
gh/lucylq/102/base
111 of 114 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
lucylq
added a commit
that referenced
this pull request
Sep 2, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #13717 by @lucylq ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/102/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/102/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/102/orig @diff-train-skip-merge Co-authored-by: lucylq <lfq@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Deprecate the module class in pybindings, previously it was blocked by bundled program, and now it's resolved with
executorch/extension/module/bundled_module.h
Line 4 in 2bb567f
Differential Revision: D70516347