Skip to content

Use extension module for pybind #13858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2025
Merged

Use extension module for pybind #13858

merged 1 commit into from
Sep 2, 2025
+81 −290

Conversation

pytorchbot
Copy link
Collaborator

This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #13717 by @lucylq
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/102/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/102/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/102/orig
@diff-train-skip-merge

@lucylq
Use extension module for pybind
d15ceb6 
Pull Request resolved: #13717

Deprecate the module class in pybindings, previously it was blocked by bundled program, and now it's resolved with https://github.com/pytorch/executorch/blob/2bb567f15a54fbc0ef621e5e85ff24e5da505b11/extension/module/bundled_module.h#L4
ghstack-source-id: 306625833
@exported-using-ghexport

Differential Revision: [D70516347](https://our.internmc.facebook.com/intern/diff/D70516347/)
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 2, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13858

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit d15ceb6 with merge base 2107afa (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 2, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@lucylq lucylq merged commit 185c96a into main Sep 2, 2025
113 of 116 checks passed
@lucylq lucylq deleted the gh/lucylq/102/orig branch September 2, 2025 21:54
kimishpatel
kimishpatel reviewed Sep 3, 2025
View reviewed changes
extension/pybindings/pybindings.cpp
nullptr, // memory_allocator
nullptr, // temp_allocator
enable_etdump ? std::make_unique<torch::executor::ETDumpGen>() : nullptr,
debug_buffer_size,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this accidentally dropped? Some of the internal stuff i was testing was broken due to this i think

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks - probably needs a test..

lucylq added a commit that referenced this pull request Sep 3, 2025
@lucylq
Revert "Use extension module for pybind (#13858)"
4fab9ef 
This reverts commit 185c96a.
lucylq added a commit that referenced this pull request Sep 3, 2025
@lucylq
Revert "Use extension module for pybind (#13858)"
cf86f60 
This reverts commit 185c96a.
lucylq added a commit that referenced this pull request Sep 3, 2025
@lucylq
Revert "Use extension module for pybind (#13858)"
b3044ee 
This reverts commit 185c96a.
lucylq added a commit that referenced this pull request Sep 3, 2025
@lucylq
Revert "Use extension module for pybind (#13858)" (#13911)
c393d17 
This reverts commit 185c96a.

### Summary
[PLEASE REMOVE] See [CONTRIBUTING.md's Pull
Requests](https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#pull-requests)
for ExecuTorch PR guidelines.

[PLEASE REMOVE] If this PR closes an issue, please add a `Fixes
#<issue-id>` line.

[PLEASE REMOVE] If this PR introduces a fix or feature that should be
the upcoming release notes, please add a "Release notes: <area>" label.
For a list of available release notes labels, check out
[CONTRIBUTING.md's Pull
Requests](https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#pull-requests).

### Test plan
[PLEASE REMOVE] How did you test this PR? Please write down any manual
commands you used and note down tests that you have written if
applicable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimishpatel kimishpatel kimishpatel left review comments

@lucylq lucylq lucylq approved these changes

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pytorchbot @kimishpatel @lucylq