Skip to content

Conversation

Ninja91
Copy link
Contributor

@Ninja91 Ninja91 commented Aug 29, 2025

Stack from ghstack (oldest at bottom):

Add 16A8W quantization support and test for the tanh operation in ExecutorTorch ARM backend.

This follows the pattern established for linear, mul, and sigmoid operations, extending int16 support to tanh operations.

Changes:

  • Add INT16 dtype validation support in op_tanh.py
  • Add test_tanh_tensor_16a8w_tosa_INT test function
  • Enable test_tanh.py in test targets configuration

The 16A8W configuration uses 16-bit activations with 8-bit weights, enabling higher precision for activations while maintaining weight efficiency.

Differential Revision: D80510815

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Add 16A8W quantization support and test for the tanh operation in ExecutorTorch ARM backend.

This follows the pattern established for linear, mul, and sigmoid operations, extending int16 support to tanh operations.

Changes:
- Add INT16 dtype validation support in op_tanh.py
- Add test_tanh_tensor_16a8w_tosa_INT test function
- Enable test_tanh.py in test targets configuration

The 16A8W configuration uses 16-bit activations with 8-bit weights, enabling higher precision for activations while maintaining weight efficiency.

Differential Revision: [D80510815](https://our.internmc.facebook.com/intern/diff/D80510815/)

[ghstack-poisoned]
@Ninja91 Ninja91 requested a review from digantdesai as a code owner August 29, 2025 06:42
Copy link

pytorch-bot bot commented Aug 29, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13797

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 6 Unrelated Failures

As of commit fb443dc with merge base 1d37845 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80510815

@zingo zingo added ciflow/trunk partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm module: arm Issues related to arm backend labels Aug 29, 2025
@zingo zingo changed the title Add 16A8W support and test for tanh operation Arm backend: Add 16A8W support and test for tanh operation Aug 29, 2025
@digantdesai digantdesai requested a review from per August 29, 2025 20:03
Add 16A8W quantization support and test for the tanh operation in ExecutorTorch ARM backend.

This follows the pattern established for linear, mul, and sigmoid operations, extending int16 support to tanh operations.

Changes:
- Add INT16 dtype validation support in op_tanh.py
- Add test_tanh_tensor_16a8w_tosa_INT test function
- Enable test_tanh.py in test targets configuration

The 16A8W configuration uses 16-bit activations with 8-bit weights, enabling higher precision for activations while maintaining weight efficiency.

Differential Revision: [D80510815](https://our.internmc.facebook.com/intern/diff/D80510815/)

cc digantdesai freddan80 per zingo oscarandersson8218

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80510815

Add 16A8W quantization support and test for the tanh operation in ExecutorTorch ARM backend.

This follows the pattern established for linear, mul, and sigmoid operations, extending int16 support to tanh operations.

Changes:
- Add INT16 dtype validation support in op_tanh.py
- Add test_tanh_tensor_16a8w_tosa_INT test function
- Enable test_tanh.py in test targets configuration

The 16A8W configuration uses 16-bit activations with 8-bit weights, enabling higher precision for activations while maintaining weight efficiency.

Differential Revision: [D80510815](https://our.internmc.facebook.com/intern/diff/D80510815/)

cc digantdesai freddan80 per zingo oscarandersson8218

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80510815

Add 16A8W quantization support and test for the tanh operation in ExecutorTorch ARM backend.

This follows the pattern established for linear, mul, and sigmoid operations, extending int16 support to tanh operations.

Changes:
- Add INT16 dtype validation support in op_tanh.py
- Add test_tanh_tensor_16a8w_tosa_INT test function
- Enable test_tanh.py in test targets configuration

The 16A8W configuration uses 16-bit activations with 8-bit weights, enabling higher precision for activations while maintaining weight efficiency.

Differential Revision: [D80510815](https://our.internmc.facebook.com/intern/diff/D80510815/)

cc digantdesai freddan80 per zingo oscarandersson8218

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80510815

@Ninja91 Ninja91 added the release notes: arm Changes to the ARM backend delegate label Sep 8, 2025
Add 16A8W quantization support and test for the tanh operation in ExecutorTorch ARM backend.

This follows the pattern established for linear, mul, and sigmoid operations, extending int16 support to tanh operations.

Changes:
- Add INT16 dtype validation support in op_tanh.py
- Add test_tanh_tensor_16a8w_tosa_INT test function
- Enable test_tanh.py in test targets configuration

The 16A8W configuration uses 16-bit activations with 8-bit weights, enabling higher precision for activations while maintaining weight efficiency.

Differential Revision: [D80510815](https://our.internmc.facebook.com/intern/diff/D80510815/)

cc digantdesai freddan80 per zingo oscarandersson8218

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80510815

Add 16A8W quantization support and test for the tanh operation in ExecutorTorch ARM backend.

This follows the pattern established for linear, mul, and sigmoid operations, extending int16 support to tanh operations.

Changes:
- Add INT16 dtype validation support in op_tanh.py
- Add test_tanh_tensor_16a8w_tosa_INT test function
- Enable test_tanh.py in test targets configuration

The 16A8W configuration uses 16-bit activations with 8-bit weights, enabling higher precision for activations while maintaining weight efficiency.

Differential Revision: [D80510815](https://our.internmc.facebook.com/intern/diff/D80510815/)

cc digantdesai freddan80 per zingo oscarandersson8218

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80510815

Add 16A8W quantization support and test for the tanh operation in ExecutorTorch ARM backend.

This follows the pattern established for linear, mul, and sigmoid operations, extending int16 support to tanh operations.

Changes:
- Add INT16 dtype validation support in op_tanh.py
- Add test_tanh_tensor_16a8w_tosa_INT test function
- Enable test_tanh.py in test targets configuration

The 16A8W configuration uses 16-bit activations with 8-bit weights, enabling higher precision for activations while maintaining weight efficiency.

Differential Revision: [D80510815](https://our.internmc.facebook.com/intern/diff/D80510815/)

cc digantdesai freddan80 per zingo oscarandersson8218

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80510815

Add 16A8W quantization support and test for the tanh operation in ExecutorTorch ARM backend.

This follows the pattern established for linear, mul, and sigmoid operations, extending int16 support to tanh operations.

Changes:
- Add INT16 dtype validation support in op_tanh.py
- Add test_tanh_tensor_16a8w_tosa_INT test function
- Enable test_tanh.py in test targets configuration

The 16A8W configuration uses 16-bit activations with 8-bit weights, enabling higher precision for activations while maintaining weight efficiency.

Differential Revision: [D80510815](https://our.internmc.facebook.com/intern/diff/D80510815/)

cc digantdesai freddan80 per zingo oscarandersson8218

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80510815

@facebook-github-bot facebook-github-bot merged commit 563fc78 into gh/Ninja91/10/base Sep 11, 2025
295 of 303 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/Ninja91/10/head branch September 11, 2025 15:18
Ninja91 added a commit that referenced this pull request Sep 11, 2025
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #13797 by
@Ninja91
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/Ninja91/10/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/Ninja91/10/head
Merge bot PR base:
https://github.com/pytorch/executorch/tree/gh/Ninja91/9/orig
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/Ninja91/10/orig
@diff-train-skip-merge

---------

Co-authored-by: Nitin Jain <jainnitin@meta.com>
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
…4214)

This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: pytorch#13797 by
@Ninja91
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/Ninja91/10/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/Ninja91/10/head
Merge bot PR base:
https://github.com/pytorch/executorch/tree/gh/Ninja91/9/orig
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/Ninja91/10/orig
@diff-train-skip-merge

---------

Co-authored-by: Nitin Jain <jainnitin@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported module: arm Issues related to arm backend partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants