Skip to content

Make token and stat callback optional in multimodal runner #13872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 4, 2025
Merged

Make token and stat callback optional in multimodal runner #13872

merged 3 commits into from
Sep 4, 2025

Conversation

jackzhxng
Copy link
Contributor

@jackzhxng jackzhxng commented Sep 2, 2025 •
edited
Loading

(Messed up the merge for the original stack, this is reland. Original PR with comments here - #13664)

Stack from ghstack (oldest at bottom):

Differential Revision: D81498751

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 2, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13872

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 84527ff with merge base ea5cf49 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Sep 2, 2025
Merged
Merged
Merged
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 2, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@jackzhxng
Copy link
Contributor Author

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jackzhxng
Update on "Make token and stat callback optional in multimodal runner"
13409cc 
(Messed up the merge for the original stack, this is reland. Original PR with comments here - #13664)


Differential Revision: [D81498751](https://our.internmc.facebook.com/intern/diff/D81498751)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D81498751

@jackzhxng
Update on "Make token and stat callback optional in multimodal runner"
84527ff 
(Messed up the merge for the original stack, this is reland. Original PR with comments here - #13664)


Differential Revision: [D81498751](https://our.internmc.facebook.com/intern/diff/D81498751)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D81498751

@facebook-github-bot facebook-github-bot merged commit 95f36a7 into gh/jackzhxng/36/base Sep 4, 2025
113 of 118 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/jackzhxng/36/head branch September 4, 2025 17:07
@pytorchbot pytorchbot mentioned this pull request Sep 4, 2025
Merged
jackzhxng added a commit that referenced this pull request Sep 4, 2025
@pytorchbot @jackzhxng
Make token and stat callback optional in multimodal runner (#13950)
e289f6c 
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #13872 by
@jackzhxng
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/jackzhxng/36/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/jackzhxng/36/head
Merge bot PR base:
https://github.com/pytorch/executorch/tree/gh/jackzhxng/35/orig
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/jackzhxng/36/orig
@diff-train-skip-merge

---------

Co-authored-by: Jack Zhang <32371937+jackzhxng@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergennachin mergennachin mergennachin approved these changes

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@swolchok swolchok Awaiting requested review from swolchok swolchok is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackzhxng @facebook-github-bot @mergennachin