Add Voxtral runner #13871
Merged
Add Voxtral runner #13871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
jackzhxng
requested review from
kirklandsign,
larryliu0820,
lucylq,
mergennachin and
swolchok
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13871
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit f2336f3 with merge base ea5cf49 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Sep 2, 2025
meta-cla
bot
added
the
CLA Signed
|
@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
jackzhxng
added
the
release notes: examples
mergennachin
approved these changes
Sep 2, 2025
swolchok
reviewed
Sep 2, 2025
Comment on lines
+85
to
+88
| std::vector<float> audio_data(batch_size * n_bins * n_frames); | ||
| f.read( | ||
| reinterpret_cast<char*>(audio_data.data()), | ||
| audio_data.size() * sizeof(float)); |
There was a problem hiding this comment.
why allocate a vector and then later copy it into audio->data? instead we can f.read directly into audio->data.data()
|
Thanks for the drive by @swolchok ! |
(Messed up the merge for the original stack, this is reland. Original PR with comments here - #13663) Differential Revision: [D81498749](https://our.internmc.facebook.com/intern/diff/D81498749) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D81498749 |
(Messed up the merge for the original stack, this is reland. Original PR with comments here - #13663) Differential Revision: [D81498749](https://our.internmc.facebook.com/intern/diff/D81498749) [ghstack-poisoned]
jackzhxng
added a commit
that referenced
this pull request
Sep 4, 2025
Pull Request resolved: #13871 @imported-using-ghimport Differential Revision: [D81498749](https://our.internmc.facebook.com/intern/diff/D81498749/) ghstack-source-id: 307512426
|
This pull request was exported from Phabricator. Differential Revision: D81498749 |
facebook-github-bot
merged commit a03a031
into
gh/jackzhxng/35/base
115 of 118 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
Merged
jackzhxng
added a commit
that referenced
this pull request
Sep 4, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #13871 by @jackzhxng ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/jackzhxng/35/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/jackzhxng/35/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/jackzhxng/34/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/jackzhxng/35/orig @diff-train-skip-merge --------- Co-authored-by: Jack Zhang <32371937+jackzhxng@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Messed up the merge for the original stack, this is reland. Original PR with comments here - #13663)
Stack from ghstack (oldest at bottom):
Differential Revision: D81498749