Skip to content

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented Sep 5, 2025

Stack from ghstack (oldest at bottom):

Deprecate the module class in pybindings, previously it was blocked by bundled program, and now it's resolved with

Old diff: D70516347

Changes from the old diff:
Use TensorPtr for output tensor instead of std::vector<uint8_t>. This allows us to use the module interface, without extracting the method, which is being deprecated.

TODO: support etdump

Differential Revision: D81607791

Deprecate the module class in pybindings, previously it was blocked by bundled program, and now it's resolved with https://github.com/pytorch/executorch/blob/2bb567f15a54fbc0ef621e5e85ff24e5da505b11/extension/module/bundled_module.h#L4

Old diff: D70516347

Changes from the old diff:
Use TensorPtr for output tensor instead of std::vector<uint8_t>. This allows us to use the module interface, without extracting the method, which is being deprecated.

TODO: support etdump

Differential Revision: [D81607791](https://our.internmc.facebook.com/intern/diff/D81607791/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Sep 5, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13986

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures

As of commit 1189938 with merge base 19d22ab (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 5, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D81607791

Copy link

github-actions bot commented Sep 5, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

lucylq added a commit that referenced this pull request Sep 5, 2025
#13986

Deprecate the module class in pybindings, previously it was blocked by bundled program, and now it's resolved with https://github.com/pytorch/executorch/blob/2bb567f15a54fbc0ef621e5e85ff24e5da505b11/extension/module/bundled_module.h#L4

Old diff: D70516347

Changes from the old diff:
Use TensorPtr for output tensor instead of std::vector<uint8_t>. This allows us to use the module interface, without extracting the method, which is being deprecated.

Next diff: support etdump

Differential Revision: [D81607791](https://our.internmc.facebook.com/intern/diff/D81607791/)

[ghstack-poisoned]
@lucylq lucylq closed this Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants