[retake] Use extension module for pybind #14024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#13986 Deprecate the module class in pybindings, previously it was blocked by bundled program, and now it's resolved with https://github.com/pytorch/executorch/blob/2bb567f15a54fbc0ef621e5e85ff24e5da505b11/extension/module/bundled_module.h#L4 Old diff: D70516347 Changes from the old diff: Use TensorPtr for output tensor instead of std::vector<uint8_t>. This allows us to use the module interface, without extracting the method, which is being deprecated. Next diff: support etdump Differential Revision: [D81607791](https://our.internmc.facebook.com/intern/diff/D81607791/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14024
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit cf03624 with merge base 2261848 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D81607791 |
This PR needs a
|
Gasoonjia
approved these changes
Sep 5, 2025
facebook-github-bot
merged commit 6b5270a
into
gh/lucylq/106/base
198 of 212 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
lucylq
added a commit
that referenced
this pull request
Sep 6, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #14024 by @lucylq ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/106/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/106/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/106/orig @diff-train-skip-merge --------- Co-authored-by: lucylq <lfq@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
#13986
Deprecate the module class in pybindings, previously it was blocked by bundled program, and now it's resolved with
executorch/extension/module/bundled_module.h
Line 4 in 2bb567f
Old diff: D70516347
Changes from the old diff:
Use TensorPtr for output tensor instead of std::vector<uint8_t>. This allows us to use the module interface, without extracting the method, which is being deprecated.
Next diff: support etdump
Differential Revision: D81607791