Add segment_data_size to extended header #14091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store the segment data size. Allows us to calculate the total PTE file size and error out if the full PTE file was not downloaded. Next diff: check file size at runtime. Differential Revision: [D81829663](https://our.internmc.facebook.com/intern/diff/D81829663/) [ghstack-poisoned]
lucylq
requested review from
JacobSzwejbka,
larryliu0820 and
mergennachin
as code owners
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D81829663 |
This PR needs a
|
Store the segment data size. Allows us to calculate the total PTE file size and error out if the full PTE file was not downloaded. Next diff: check file size at runtime. Differential Revision: [D81829663](https://our.internmc.facebook.com/intern/diff/D81829663/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Sep 8, 2025
Pull Request resolved: #14091 Store the segment data size. Allows us to calculate the total PTE file size and error out if the full PTE file was not downloaded. Next diff: check file size at runtime. ghstack-source-id: 308339726 @exported-using-ghexport Differential Revision: [D81829663](https://our.internmc.facebook.com/intern/diff/D81829663/)
|
This pull request was exported from Phabricator. Differential Revision: D81829663 |
Store the segment data size. Allows us to calculate the total PTE file size and error out if the full PTE file was not downloaded. Next diff: check file size at runtime. Differential Revision: [D81829663](https://our.internmc.facebook.com/intern/diff/D81829663/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Sep 10, 2025
Pull Request resolved: #14091 Store the segment data size. Allows us to calculate the total PTE file size and error out if the full PTE file was not downloaded. Next diff: check file size at runtime. ghstack-source-id: 308834125 @exported-using-ghexport Differential Revision: [D81829663](https://our.internmc.facebook.com/intern/diff/D81829663/)
|
This pull request was exported from Phabricator. Differential Revision: D81829663 |
mergennachin
approved these changes
Sep 10, 2025
Store the segment data size. Allows us to calculate the total PTE file size and error out if the full PTE file was not downloaded. Next diff: check file size at runtime. Differential Revision: [D81829663](https://our.internmc.facebook.com/intern/diff/D81829663/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D81829663 |
Store the segment data size. Allows us to calculate the total PTE file size and error out if the full PTE file was not downloaded. Next diff: check file size at runtime. Differential Revision: [D81829663](https://our.internmc.facebook.com/intern/diff/D81829663/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D81829663 |
facebook-github-bot
merged commit 627211c
into
gh/lucylq/107/base
536 of 629 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
lucylq
added a commit
that referenced
this pull request
Sep 11, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #14091 by @lucylq ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/107/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/107/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/107/orig @diff-train-skip-merge --------- Co-authored-by: lucylq <lfq@meta.com>
StrycekSimon
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Sep 23, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: pytorch#14091 by @lucylq ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/107/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/107/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/107/orig @diff-train-skip-merge --------- Co-authored-by: lucylq <lfq@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Store the segment data size. Allows us to calculate the total PTE file size and error out if the full PTE file was not downloaded.
Next diff: check file size at runtime.
Differential Revision: D81829663