Add segment_data_size to extended header #14226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request resolved: #14091 Store the segment data size. Allows us to calculate the total PTE file size and error out if the full PTE file was not downloaded. Next diff: check file size at runtime. ghstack-source-id: 308927510 @exported-using-ghexport Differential Revision: [D81829663](https://our.internmc.facebook.com/intern/diff/D81829663/)
pytorchbot
requested review from
JacobSzwejbka,
larryliu0820,
lucylq and
mergennachin
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14226
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 54 PendingAs of commit 28eda12 with merge base 598ba46 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
This PR needs a
|
mergennachin
approved these changes
Sep 11, 2025
lucylq
approved these changes
Sep 11, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #14092 by @lucylq ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/108/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/108/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/107/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/108/orig @diff-train-skip-merge Co-authored-by: lucylq <lfq@meta.com>
StrycekSimon
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Sep 23, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: pytorch#14091 by @lucylq ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/107/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/107/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/107/orig @diff-train-skip-merge --------- Co-authored-by: lucylq <lfq@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #14091 by @lucylq
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/107/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/107/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/107/orig
@diff-train-skip-merge