Deprecate debug buffer in Module #14161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's in release 0.7 so can't remove it, following deprecation schedule. debug_buffer is part of the event tracer, which is passed into Module. There isn't a public API on event tracer to set the debug_buffer, so the one held by Module is always empty. Added in D71135352 for pybindings migration, however the debug buffer is held by PyModule in that case. Differential Revision: [D82125911](https://our.internmc.facebook.com/intern/diff/D82125911/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14161
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 Cancelled Jobs, 37 Pending, 3 Unrelated FailuresAs of commit 91309cd with merge base 598ba46 ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
lucylq
added a commit
that referenced
this pull request
Sep 10, 2025
It's in release 0.7 so can't remove it, following deprecation schedule. debug_buffer is part of the event tracer, which is passed into Module. There isn't a public API on event tracer to set the debug_buffer, so the one held by Module is always empty. Added in D71135352 for pybindings migration, however the debug buffer is held by PyModule in that case. Differential Revision: [D82125911](https://our.internmc.facebook.com/intern/diff/D82125911/) ghstack-source-id: 308805142 Pull Request resolved: #14161
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D82125911 |
This PR needs a
|
It's in release 0.7 so can't remove it, following deprecation schedule. debug_buffer is part of the event tracer, which is passed into Module. There isn't a public API on event tracer to set the debug_buffer, so the one held by Module is always empty. Added in D71135352 for pybindings migration, however the debug buffer is held by PyModule in that case. Differential Revision: [D82125911](https://our.internmc.facebook.com/intern/diff/D82125911/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Sep 10, 2025
Pull Request resolved: #14161 It's in release 0.7 so following deprecation schedule. debug_buffer is part of the event tracer, which is passed into Module. There isn't a public API on event tracer to set the debug_buffer, so the one held by Module is always empty. Added in D71135352 for pybindings migration, however the debug buffer is held by PyModule in that case. ghstack-source-id: 308829478 @exported-using-ghexport Differential Revision: [D82125911](https://our.internmc.facebook.com/intern/diff/D82125911/)
|
This pull request was exported from Phabricator. Differential Revision: D82125911 |
It's in release 0.7 so can't remove it, following deprecation schedule. debug_buffer is part of the event tracer, which is passed into Module. There isn't a public API on event tracer to set the debug_buffer, so the one held by Module is always empty. Added in D71135352 for pybindings migration, however the debug buffer is held by PyModule in that case. Differential Revision: [D82125911](https://our.internmc.facebook.com/intern/diff/D82125911/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Sep 10, 2025
Pull Request resolved: #14161 It's in release 0.7 so following deprecation schedule. debug_buffer is part of the event tracer, which is passed into Module. There isn't a public API on event tracer to set the debug_buffer, so the one held by Module is always empty. Added in D71135352 for pybindings migration, however the debug buffer is held by PyModule in that case. ghstack-source-id: 308926514 @exported-using-ghexport Differential Revision: [D82125911](https://our.internmc.facebook.com/intern/diff/D82125911/)
|
This pull request was exported from Phabricator. Differential Revision: D82125911 |
facebook-github-bot
merged commit c091589
into
gh/lucylq/112/base
426 of 468 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
lucylq
added a commit
that referenced
this pull request
Sep 11, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #14161 by @lucylq ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/112/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/112/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/112/orig @diff-train-skip-merge Co-authored-by: lucylq <lfq@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
It's in release 0.7 so can't remove it, following deprecation schedule.
debug_buffer is part of the event tracer, which is passed into Module. There isn't a public API on event tracer to set the debug_buffer, so the one held by Module is always empty.
Added in D71135352 for pybindings migration, however the debug buffer is held by PyModule in that case.
Differential Revision: D82125911