Skip to content

Deprecate debug buffer in Module #14161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 11, 2025
Merged

Deprecate debug buffer in Module #14161

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f68d4ff
Deprecate debug buffer in Module
lucylq Sep 10, 2025
942306a
Update on "Deprecate debug buffer in Module"
lucylq Sep 10, 2025
91309cd
Update on "Deprecate debug buffer in Module"
lucylq Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions extension/module/module.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,8 +598,9 @@ class Module {
return event_tracer_.get();
}

ET_NODISCARD
runtime::Span<uint8_t> debug_buffer() {
// Note: this debug_buffer will always be empty. The one being used is in
// the event_tracer attached to module. Please use that one.
ET_DEPRECATED ET_NODISCARD runtime::Span<uint8_t> debug_buffer() {
return runtime::Span<uint8_t>(debug_buffer_.data(), debug_buffer_.size());
}

Expand All @@ -622,7 +623,7 @@ class Module {
std::unique_ptr<runtime::EventTracer> event_tracer_;
std::unique_ptr<runtime::DataLoader> data_map_loader_;
std::unique_ptr<NamedDataMap> data_map_;
std::vector<uint8_t> debug_buffer_;
ET_DEPRECATED std::vector<uint8_t> debug_buffer_;

protected:
std::unordered_map<std::string, MethodHolder> methods_;
Expand Down
Loading