Skip to content

Conversation

metascroy
Copy link
Contributor

This PR bumps the torchao pin in ExecuTorch, and adjusts the code in ExecuTorch to rely less on deprecated features. In particular,

Copy link

pytorch-bot bot commented Sep 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14171

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (19 Unrelated Failures)

As of commit 164f489 with merge base 56d5186 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 10, 2025
@metascroy metascroy added ciflow/trunk and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Sep 10, 2025
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 10, 2025
abhinaykukkadapu added a commit to abhinaykukkadapu/executorch that referenced this pull request Sep 10, 2025
Summary: `quantize_()` modifies model in place, we need to make a copy to avoid making changes to user passed model. Fix a bug as discussed in pytorch#14171 (comment)

Differential Revision: D82167495
abhinaykukkadapu added a commit to abhinaykukkadapu/executorch that referenced this pull request Sep 10, 2025
…ge (pytorch#14186)

Summary:

`quantize_()` modifies model in place, we need to make a copy to avoid making changes to user passed model. Fix a bug as discussed in pytorch#14171 (comment)

Differential Revision: D82167495
abhinaykukkadapu added a commit to abhinaykukkadapu/executorch that referenced this pull request Sep 11, 2025
…ge (pytorch#14186)

Summary:

`quantize_()` modifies model in place, we need to make a copy to avoid making changes to user passed model. Fix a bug as discussed in pytorch#14171 (comment)

Differential Revision: D82167495
# Test with different group sizes
for group_size in [8, 16, 32]:
with self.subTest(group_size=group_size):
model_to_export = copy.deepcopy(model)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@metascroy can you try without a copy here, as the PR i landed should take care of this within the source transform stage.

@metascroy metascroy merged commit a4b7de0 into main Sep 11, 2025
300 of 305 checks passed
@metascroy metascroy deleted the bump-ao-pin branch September 11, 2025 18:51
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
This PR bumps the torchao pin in ExecuTorch, and adjusts the code in
ExecuTorch to rely less on deprecated features. In particular,

* torchao/experimental folder is being deprecated, so we switch
embedding / tied embedding quantizers to their new home
* v1 tensors based on AffineQuantizedTensor + QDQLayout are being
deprecated. This switches ExecuTorch to use v2 tensors. See
pytorch/ao#2967.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants